You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by NickManley <gi...@git.apache.org> on 2016/01/24 08:37:21 UTC
[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...
GitHub user NickManley opened a pull request:
https://github.com/apache/commons-lang/pull/121
DiffBuilder: Add null check on fieldName when appending Object or Object[]
The other append methods throw an IllegalArgumentException if fieldName is null. So, I added it here as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NickManley/commons-lang nullcheck
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit bec30ff404ea52b822ee47d9e6271b789697c19c
Author: Nick Manley <ni...@outlook.com>
Date: 2016-01-24T05:35:23Z
Add null check on fieldName when appending Object or Object[].
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/121#issuecomment-220402340
Merged. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/121#issuecomment-220398409
I created a issue to track this: https://issues.apache.org/jira/browse/LANG-1232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...
Posted by NickManley <gi...@git.apache.org>.
Github user NickManley commented on the pull request:
https://github.com/apache/commons-lang/pull/121#issuecomment-220787893
Thank you, Pascal. Closing this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/121#issuecomment-220791849
Thanks Nick!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...
Posted by NickManley <gi...@git.apache.org>.
Github user NickManley closed the pull request at:
https://github.com/apache/commons-lang/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/121#issuecomment-217722238
@NickManley Thanks for the pull request.
It would be very nice if you would create a jira issue for this at: https://issues.apache.org/jira/browse/LANG/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---