You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2016/05/06 09:28:25 UTC
[GitHub] brooklyn-docs pull request: Update the tests documentation
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-docs/pull/55
Update the tests documentation
It explicitly says that the target for a test can be omitted if wrapped into a TestCase that already defines the target.
Here is how it looks like:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-docs fix/test-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-docs/pull/55.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #55
----
commit e32ae081735057b658b042ebf67e134e32d6ef82
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Date: 2016-05-06T09:23:09Z
Update the tests documentation to explicitly say that the target can be omitted if wrapped into a TestCase that already defines the target
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-docs pull request: Update the tests documentation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-docs/pull/55#issuecomment-217948776
no, not at all worth refactoring, just wanted to let you know
at some point it would be worth refactoring this page so it has sub-menu entries and isn't one long scroll but it's eminently usable which is the main thing for now
as for longer text in templates, completely agree ... one day wouldn't it be nice to have integrated w angular or reach, to be able to define `<alert>` and then `<tip-testcases>` so we could inline just write `<tip-testcases type="TestEffector">`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-docs pull request: Update the tests documentation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/55#discussion_r62546531
--- Diff: guide/yaml/test/test-entities.md ---
@@ -89,6 +93,10 @@ The `TestEffector` entity invokes the specified effector on a target entity. If
- `params` - parameters to pass to the effector, these will depend on the entity and effector being tested. The example above shows the `url` and `targetName` parameters being passed to Tomcats `deploy` effector.
- `assert` - assertion to perform on the returned result. See section on assertions below.
+<div class="alert alert-info">
--- End diff --
this would be a good candidate for a partial/include following the pattern of `_includes/feature-item.html` as used in `website//learnmore/features/*.md` -- you could just write
{% include tip-testcase.html title="TestEffector" %}
also curious why you're using html rather than md syntax
but both comments are pedantic, feel free to ignore
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-docs pull request: Update the tests documentation
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/55#discussion_r62547620
--- Diff: guide/yaml/test/test-entities.md ---
@@ -89,6 +93,10 @@ The `TestEffector` entity invokes the specified effector on a target entity. If
- `params` - parameters to pass to the effector, these will depend on the entity and effector being tested. The example above shows the `url` and `targetName` parameters being passed to Tomcats `deploy` effector.
- `assert` - assertion to perform on the returned result. See section on assertions below.
+<div class="alert alert-info">
--- End diff --
The `include` seems nice but the line will become quite long depending on the text to pass right?
As for using HTML over md, I didn't know I could use markdown inside HTML so quite happy to change if you prefer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-docs pull request: Update the tests documentation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---