You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2013/10/18 16:51:01 UTC
Re: svn commit: r1533435 - /commons/proper/jcs/trunk/pom.xml
On 18 October 2013 14:02, <tv...@apache.org> wrote:
> Author: tv
> Date: Fri Oct 18 13:02:03 2013
> New Revision: 1533435
>
> URL: http://svn.apache.org/r1533435
> Log:
> Derive groupId from parent
-1
Sorry, but I don't think this is wise.
The groupId is a critical aspect of each component; it's vital that
this is explicit.
> Modified:
> commons/proper/jcs/trunk/pom.xml
>
> Modified: commons/proper/jcs/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/jcs/trunk/pom.xml?rev=1533435&r1=1533434&r2=1533435&view=diff
> ==============================================================================
> --- commons/proper/jcs/trunk/pom.xml (original)
> +++ commons/proper/jcs/trunk/pom.xml Fri Oct 18 13:02:03 2013
> @@ -25,7 +25,6 @@
> <artifactId>commons-parent</artifactId>
> <version>32</version>
> </parent>
> - <groupId>org.apache.commons</groupId>
> <artifactId>commons-jcs</artifactId>
> <packaging>jar</packaging>
> <version>2.0-SNAPSHOT</version>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1533435 - /commons/proper/jcs/trunk/pom.xml
Posted by sebb <se...@gmail.com>.
On 18 October 2013 16:05, Emmanuel Bourg <eb...@apache.org> wrote:
> Le 18/10/2013 16:51, sebb a écrit :
>
>> -1
>>
>> Sorry, but I don't think this is wise.
>> The groupId is a critical aspect of each component; it's vital that
>> this is explicit.
>
> Well, it's explicitly defined in the <parent> declaration just above,
> isn't it?
Yes, but the parent groupId does not *have* to be the same as the
component groupId; indeed there are several components for which this
is not the case.
And it would be potentially possible to switch to a parent with a
different groupId.
If the component groupId is omitted, it is not clear whether the
omission is accidental or deliberate.
> Emmanuel Bourg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1533435 - /commons/proper/jcs/trunk/pom.xml
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 18/10/2013 16:51, sebb a écrit :
> -1
>
> Sorry, but I don't think this is wise.
> The groupId is a critical aspect of each component; it's vital that
> this is explicit.
Well, it's explicitly defined in the <parent> declaration just above,
isn't it?
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1533435 - /commons/proper/jcs/trunk/pom.xml
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 18/10/2013 17:26, Thomas Vandahl a écrit :
> This was actually a recommendation of the m2eclipse plugin. I thought it was a good idea.
> I'roll it back.
And IntelliJ recommends the same thing too.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1533435 - /commons/proper/jcs/trunk/pom.xml
Posted by sebb <se...@gmail.com>.
On 18 October 2013 16:26, Thomas Vandahl <tv...@apache.org> wrote:
>
>> Am 18.10.2013 um 16:51 schrieb sebb <se...@gmail.com>:
>>
>>> On 18 October 2013 14:02, <tv...@apache.org> wrote:
>>> Author: tv
>>> Date: Fri Oct 18 13:02:03 2013
>>> New Revision: 1533435
>>>
>>> URL: http://svn.apache.org/r1533435
>>> Log:
>>> Derive groupId from parent
>>
>> -1
>>
>> Sorry, but I don't think this is wise.
>> The groupId is a critical aspect of each component; it's vital that
>> this is explicit.
>
> This was actually a recommendation of the m2eclipse plugin. I thought it was a good idea.
> I'roll it back.
Thanks!
> Bye, Thomas.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1533435 - /commons/proper/jcs/trunk/pom.xml
Posted by Thomas Vandahl <tv...@apache.org>.
> Am 18.10.2013 um 16:51 schrieb sebb <se...@gmail.com>:
>
>> On 18 October 2013 14:02, <tv...@apache.org> wrote:
>> Author: tv
>> Date: Fri Oct 18 13:02:03 2013
>> New Revision: 1533435
>>
>> URL: http://svn.apache.org/r1533435
>> Log:
>> Derive groupId from parent
>
> -1
>
> Sorry, but I don't think this is wise.
> The groupId is a critical aspect of each component; it's vital that
> this is explicit.
This was actually a recommendation of the m2eclipse plugin. I thought it was a good idea.
I'roll it back.
Bye, Thomas.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org