[jira] [Commented] (JCRVLT-241) Goal analyze-classes: Dependencies with type "bundle" not correctly considered

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274390#comment-16274390 ] 

Konrad Windszus commented on JCRVLT-241:
----------------------------------------

bq. didn't know about the .bundle type. sounds wrong to me to create such artifacts. a jar is a jar is a jar 

This is the same as {{zip}} vs. {{content-package}}. In theory there might be a benefit of referencing bundle dependencies via {{bundle}} than via {{jar}} if the support in the {{maven-bundle-plugin}} (compare with https://issues.apache.org/jira/browse/FELIX-4303). Anyways supporting both does not do any harm.

bq. the import package is particularly used to specify the runtime dependency on java packages. since the package build/compile isn't needed for packages, it makes no sense to use those as dependency.

Although you are right that those dependencies should be given as provided, we cannot really enforce this. Having compile scope dependencies in packages (and consider those for the import-package range) does IMHO not do any harm. Still we should encourage people to always declare them with the right scope. But the overpopulated classpath is not a problem for the calculation of import version ranges IMHO. So my question is: what do we loose if we consider other scopes as well?

> Goal analyze-classes: Dependencies with type "bundle" not correctly considered
> ------------------------------------------------------------------------------
>
>                 Key: JCRVLT-241
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-241
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.0.0
>            Reporter: Konrad Windszus
>
> The goal {{analyze-classes}} only evaluates dependencies of type "jar" (https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/trunk/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/ImportPackageBuilder.java#L150). This is not correct as even type "bundle" (being supported through the {{maven-bundle-plugin}}) contains OSGi bundles.
> That leads to the fact that the version cannot be determined for dependencies towards packages from bundle type dependencies.
> Also I am wondering why only dependencies with scope "provided" or "runtime" should be considered. Very often dependencies are having the default scope only (i.e. compile) which should not cause any issues.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)