You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/08/03 22:34:36 UTC
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1312: nimble/phy/nrf: Fix possible MIC error
apache-mynewt-bot commented on PR #1312:
URL: https://github.com/apache/mynewt-nimble/pull/1312#issuecomment-1204551323
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/drivers/nrf52/src/ble_phy.c
<details>
```diff
@@ -1103,7 +1101,7 @@
/* Only set MIC failure flag if frame is not zero length */
if (dptr[1] != 0) {
/* Make sure CCM finished */
- while(NRF_CCM->EVENTS_ENDCRYPT == 0) {
+ while (NRF_CCM->EVENTS_ENDCRYPT == 0) {
__WFE();
}
if (NRF_CCM->MICSTATUS == 0) {
```
</details>
#### nimble/drivers/nrf5340/src/ble_phy.c
<details>
```diff
@@ -961,7 +961,7 @@
/* Only set MIC failure flag if frame is not zero length */
if (dptr[1] != 0) {
/* Make sure CCM finished */
- while(NRF_CCM_NS->EVENTS_ENDCRYPT == 0) {
+ while (NRF_CCM_NS->EVENTS_ENDCRYPT == 0) {
__WFE();
}
if (NRF_CCM_NS->MICSTATUS == 0) {
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org