You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/30 14:25:44 UTC

[GitHub] [incubator-superset] Steejay commented on pull request #10482: fix: enforce mandatory chart name on save and edit

Steejay commented on pull request #10482:
URL: https://github.com/apache/incubator-superset/pull/10482#issuecomment-666398063


   @villebro pattern looks good.
   
   can we switch the button order of the Edit Chart Properties modal? Move **Save** to the right and **Cancel** to the left. sim to the Save Chart arrangement. 
   
   can we also change the color of the active state for the **Save** button to #20A7C9? right now both active and disabled state are grey. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org