You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by pn...@apache.org on 2022/11/08 13:14:33 UTC

[flink] 03/03: [FLINK-29379][streaming] Drop CheckpointConfig#failOnCheckpointingErrors and use getTolerableCheckpointFailureNumber() instead

This is an automated email from the ASF dual-hosted git repository.

pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit bb124f4ada402abd98de53e3827fc227997c4e3e
Author: Piotr Nowojski <pi...@gmail.com>
AuthorDate: Fri Nov 4 13:06:24 2022 +0100

    [FLINK-29379][streaming] Drop CheckpointConfig#failOnCheckpointingErrors and use getTolerableCheckpointFailureNumber() instead
---
 .../flink/streaming/api/environment/CheckpointConfig.java   | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java
index 2937f347faf..7e59e0874c9 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java
@@ -128,16 +128,6 @@ public class CheckpointConfig implements java.io.Serializable {
      */
     private final Configuration configuration;
 
-    /**
-     * Task would not fail if there is an error in their checkpointing.
-     *
-     * <p>{@link ExecutionCheckpointingOptions#TOLERABLE_FAILURE_NUMBER} would always overrule this
-     * deprecated field if they have conflicts.
-     *
-     * @deprecated Use {@link ExecutionCheckpointingOptions#TOLERABLE_FAILURE_NUMBER}.
-     */
-    @Deprecated private boolean failOnCheckpointingErrors = true;
-
     /**
      * The checkpoint storage for this application. This field is marked as transient because it may
      * contain user-code.
@@ -380,7 +370,7 @@ public class CheckpointConfig implements java.io.Serializable {
      */
     @Deprecated
     public boolean isFailOnCheckpointingErrors() {
-        return failOnCheckpointingErrors;
+        return getTolerableCheckpointFailureNumber() == 0;
     }
 
     /**
@@ -409,7 +399,6 @@ public class CheckpointConfig implements java.io.Serializable {
                     getTolerableCheckpointFailureNumber());
             return;
         }
-        this.failOnCheckpointingErrors = failOnCheckpointingErrors;
         if (failOnCheckpointingErrors) {
             setTolerableCheckpointFailureNumber(0);
         } else {