You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/30 06:50:08 UTC

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17720: [feature][broker] Support `autoSubscriptionCreation` on topic level

AnonHxy commented on code in PR #17720:
URL: https://github.com/apache/pulsar/pull/17720#discussion_r984263219


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -3074,6 +3074,11 @@ public boolean isAllowAutoSubscriptionCreation(final TopicName topicName) {
     }
 
     private AutoSubscriptionCreationOverride getAutoSubscriptionCreationOverride(final TopicName topicName) {
+        Optional<TopicPolicies> topicPolicies = getTopicPolicies(topicName);

Review Comment:
   We should get `AutoSubscriptionCreationOverride` from `AbstractTopic#topicPolicies` I think



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org