You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/29 11:27:34 UTC

[GitHub] [flink] rmetzger opened a new pull request #14805: Minor docs

rmetzger opened a new pull request #14805:
URL: https://github.com/apache/flink/pull/14805


   Fixes two small issues in the docs.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a change in pull request #14805: [FLINK-13996][docs] Update instructions on building with Maven 3.3.x

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14805:
URL: https://github.com/apache/flink/pull/14805#discussion_r566779668



##########
File path: docs/flinkDev/building.md
##########
@@ -105,20 +105,25 @@ Flink [shades away](https://maven.apache.org/plugins/maven-shade-plugin/) some o
 
 The dependency shading mechanism was recently changed in Maven and requires users to build Flink slightly differently, depending on their Maven version:
 
-**Maven 3.1.x and 3.2.x**
+**Maven and 3.2.x**
 It is sufficient to call `mvn clean install -DskipTests` in the root directory of Flink code base.
 
 **Maven 3.3.x**
-The build has to be done in two steps: First in the base directory, then in the distribution project:
+The build has to be done in two steps: First in the base directory, then in shaded modules, such as the distribution and the filesystems:
 
 {% highlight bash %}
 mvn clean install -DskipTests
 cd flink-dist
 mvn clean install
+cd ../flink-filesystems/flink-s3-fs-presto/

Review comment:
       This should be done before flink-dist (otherwise it won't be picked up by flink-dist).
   
   Furthermore, there are so many instances by now (filesystems, metric reporters, sql connectors, flink-runtime) that we simply should not list maven 3.3 as an option.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a change in pull request #14805: [FLINK-13996][docs] Update instructions on building with Maven 3.3.x

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14805:
URL: https://github.com/apache/flink/pull/14805#discussion_r566779668



##########
File path: docs/flinkDev/building.md
##########
@@ -105,20 +105,25 @@ Flink [shades away](https://maven.apache.org/plugins/maven-shade-plugin/) some o
 
 The dependency shading mechanism was recently changed in Maven and requires users to build Flink slightly differently, depending on their Maven version:
 
-**Maven 3.1.x and 3.2.x**
+**Maven and 3.2.x**
 It is sufficient to call `mvn clean install -DskipTests` in the root directory of Flink code base.
 
 **Maven 3.3.x**
-The build has to be done in two steps: First in the base directory, then in the distribution project:
+The build has to be done in two steps: First in the base directory, then in shaded modules, such as the distribution and the filesystems:
 
 {% highlight bash %}
 mvn clean install -DskipTests
 cd flink-dist
 mvn clean install
+cd ../flink-filesystems/flink-s3-fs-presto/

Review comment:
       This should be done before flink-dist (otherwise it won't be picked up by flink-dist).
   
   Furthermore, there are so many instances by now (sql connectors) that we simply should not list maven 3.3 as an option.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a change in pull request #14805: [FLINK-13996][docs] Update instructions on building with Maven 3.3.x

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14805:
URL: https://github.com/apache/flink/pull/14805#discussion_r566779668



##########
File path: docs/flinkDev/building.md
##########
@@ -105,20 +105,25 @@ Flink [shades away](https://maven.apache.org/plugins/maven-shade-plugin/) some o
 
 The dependency shading mechanism was recently changed in Maven and requires users to build Flink slightly differently, depending on their Maven version:
 
-**Maven 3.1.x and 3.2.x**
+**Maven and 3.2.x**
 It is sufficient to call `mvn clean install -DskipTests` in the root directory of Flink code base.
 
 **Maven 3.3.x**
-The build has to be done in two steps: First in the base directory, then in the distribution project:
+The build has to be done in two steps: First in the base directory, then in shaded modules, such as the distribution and the filesystems:
 
 {% highlight bash %}
 mvn clean install -DskipTests
 cd flink-dist
 mvn clean install
+cd ../flink-filesystems/flink-s3-fs-presto/

Review comment:
       This should be done before flink-dist (otherwise it won't be picked up by flink-dist).
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a change in pull request #14805: [FLINK-13996][docs] Update instructions on building with Maven 3.3.x

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14805:
URL: https://github.com/apache/flink/pull/14805#discussion_r566779668



##########
File path: docs/flinkDev/building.md
##########
@@ -105,20 +105,25 @@ Flink [shades away](https://maven.apache.org/plugins/maven-shade-plugin/) some o
 
 The dependency shading mechanism was recently changed in Maven and requires users to build Flink slightly differently, depending on their Maven version:
 
-**Maven 3.1.x and 3.2.x**
+**Maven and 3.2.x**
 It is sufficient to call `mvn clean install -DskipTests` in the root directory of Flink code base.
 
 **Maven 3.3.x**
-The build has to be done in two steps: First in the base directory, then in the distribution project:
+The build has to be done in two steps: First in the base directory, then in shaded modules, such as the distribution and the filesystems:
 
 {% highlight bash %}
 mvn clean install -DskipTests
 cd flink-dist
 mvn clean install
+cd ../flink-filesystems/flink-s3-fs-presto/

Review comment:
       This should be done before flink-dist (otherwise it won't be picked up by flink-dist).
   
   Furthermore, there are so many instances by now (filesystems, metric reporters, sql connectors) that we simply should not list maven 3.3 as an option.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on a change in pull request #14805: [FLINK-13996][docs] Update instructions on building with Maven 3.3.x

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14805:
URL: https://github.com/apache/flink/pull/14805#discussion_r566852095



##########
File path: docs/flinkDev/building.md
##########
@@ -105,20 +105,25 @@ Flink [shades away](https://maven.apache.org/plugins/maven-shade-plugin/) some o
 
 The dependency shading mechanism was recently changed in Maven and requires users to build Flink slightly differently, depending on their Maven version:
 
-**Maven 3.1.x and 3.2.x**
+**Maven and 3.2.x**
 It is sufficient to call `mvn clean install -DskipTests` in the root directory of Flink code base.
 
 **Maven 3.3.x**
-The build has to be done in two steps: First in the base directory, then in the distribution project:
+The build has to be done in two steps: First in the base directory, then in shaded modules, such as the distribution and the filesystems:
 
 {% highlight bash %}
 mvn clean install -DskipTests
 cd flink-dist
 mvn clean install
+cd ../flink-filesystems/flink-s3-fs-presto/

Review comment:
       ah, damn, you are right.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14805: [FLINK-13996][docs] Update instructions on building with Maven 3.3.x

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14805:
URL: https://github.com/apache/flink/pull/14805#issuecomment-769749974


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 1e3102f2c1f0b01731735f898e4a9e56aa90fcbb (Fri Jan 29 11:29:41 UTC 2021)
   
   **Warnings:**
    * Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger closed pull request #14805: [FLINK-13996][docs] Update instructions on building with Maven 3.3.x

Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #14805:
URL: https://github.com/apache/flink/pull/14805


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14805: [FLINK-13996][docs] Update instructions on building with Maven 3.3.x

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14805:
URL: https://github.com/apache/flink/pull/14805#issuecomment-769749974


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 1e3102f2c1f0b01731735f898e4a9e56aa90fcbb (Fri May 28 08:14:55 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #14805: [FLINK-13996][docs] Update instructions on building with Maven 3.3.x

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14805:
URL: https://github.com/apache/flink/pull/14805#issuecomment-769752728


   Thanks for the quick review. I updated the zh version and merge it now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org