You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/09/01 14:31:41 UTC

[GitHub] [sling-org-apache-sling-scripting-sightly] paul-bjorkstrand commented on pull request #8: SLING-9715 - The JavaUseProvider does not properly handle the adaptable argument for Sling Model classes

paul-bjorkstrand commented on pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/8#issuecomment-684897864


   Ah, I gotta watch that copy-pasta. I sheepishly admit that my quick test with it was using the current resource, rather than a different one, so clearly I did not exercise that path. 😞 
   
   Thanks for that catch, @raducotescu.
   
   I will also say, that I was inches away from creating a unit test for that, but shied away due to the sheer weight of the setup code needed. To make it more easily testable, will require some significant reorganization of that class' methods.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org