You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flink.apache.org by "Cassie (Jira)" <ji...@apache.org> on 2021/12/01 03:21:00 UTC

[jira] [Created] (FLINK-25119) The name of freeSlots parameter in SlotSharingSlotAllocator#determineParallelism method is named incorrectly.

Cassie created FLINK-25119:
------------------------------

             Summary: The name of freeSlots parameter in SlotSharingSlotAllocator#determineParallelism method is named incorrectly.
                 Key: FLINK-25119
                 URL: https://issues.apache.org/jira/browse/FLINK-25119
             Project: Flink
          Issue Type: Improvement
          Components: Runtime / Coordination
    Affects Versions: 1.13.3, 1.13.2, 1.13.1, 1.14.0, 1.13.0
            Reporter: Cassie
         Attachments: image-2021-12-01-11-18-34-572.png

determineParallism方法中的第二个参数freeSlots，即为在slotpool中空闲的slot，但实际使用时，有的调用方传入的是slotpool中all slot(allocated slot and free slot)，有的调用方传入的是slotpool中free slot，因此参数名直接定义成freeSlots，不够准确，影响对determineParallism逻辑的理解。

!image-2021-12-01-11-18-34-572.png!

 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)