You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/07 19:31:11 UTC

[GitHub] [beam] robinyqiu commented on a change in pull request #12500: Fix precommit errors

robinyqiu commented on a change in pull request #12500:
URL: https://github.com/apache/beam/pull/12500#discussion_r467230770



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamSqlUnparseContext.java
##########
@@ -110,6 +111,26 @@ public SqlNode toSql(RexProgram program, RexNode rex) {
     public void unparse(SqlWriter writer, int leftPrec, int rightPrec) {
       writer.literal("DATETIME '" + timestampString.toString() + "'");
     }
+
+    @Override

Review comment:
       Ah, my bad. I only run spotless and checkStyle locally but not spotBugs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org