You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "vrajat (via GitHub)" <gi...@apache.org> on 2024/12/10 04:28:20 UTC
[I] numServersQueried, responded is not set in BrokerResponse for MSQE [pinot]
vrajat opened a new issue, #14624:
URL: https://github.com/apache/pinot/issues/14624
Reproduce:
* Start `MultiStageQueryEngineQuickStart`.
* Run the following commands:
```
# Run query using SSE
curl --request POST http://localhost:9000/sql --data '{"sql":"SELECT playerName, teamID FROM baseballStats_OFFLINE LIMIT 10", "queryOptions":"useMultistageEngine=false"}' | jq > /tmp/sse
# Run query using MSE
curl --request POST http://localhost:9000/sql --data '{"sql":"SELECT playerName, teamID FROM baseballStats_OFFLINE LIMIT 10", "queryOptions":"useMultistageEngine=true"}' | jq > /tmp/mse
```
The relevant portions of diff are:
```
diff /tmp/sse /tmp/mse
67,68c131,132
< "numServersQueried": 1,
< "numServersResponded": 1,
---
> "numServersQueried": 0,
> "numServersResponded": 0,
```
Note that lines starting with `>` are from `/tmp/mse`
Other fields are set to 0 as well but it is not clear to me if the time taken was > 0 ms.
```
81,82c145,146
< "brokerReduceTimeMs": 0,
< "offlineThreadCpuTimeNs": 129000,
---
> "brokerReduceTimeMs": 2,
> "offlineThreadCpuTimeNs": 0,
84c148
< "offlineSystemActivitiesCpuTimeNs": 44042,
---
> "offlineSystemActivitiesCpuTimeNs": 0,
86c150
< "offlineResponseSerializationCpuTimeNs": 9000,
---
> "offlineResponseSerializationCpuTimeNs": 0,
88c152
< "offlineTotalCpuTimeNs": 182042,
---
> "offlineTotalCpuTimeNs": 0,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] numServersQueried, responded is not set in BrokerResponse for MSQE [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on issue #14624:
URL: https://github.com/apache/pinot/issues/14624#issuecomment-2535893269
Looks like this was left as a TODO - https://github.com/apache/pinot/blob/b4066fbd40cce1e035a70968382fc24b3b7f4427/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java#L256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] numServersQueried, responded is not set in BrokerResponse for MSQE [pinot]
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on issue #14624:
URL: https://github.com/apache/pinot/issues/14624#issuecomment-2560813357
> It should be fairly straightforward to get the servers queried from the query plan in the broker. I'm not sure if there's a straightforward way to get the servers responded stats though.
I think in MSE there is now way a query can finish successfully if a queried server doesn't respond. So in successful queries we can always return the same value used in server queries. What I don't think it is worth it is to try to calculate how many servers didn't answer. That makes sense in SSE where users can choose availability over consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] numServersQueried, responded is not set in BrokerResponse for MSQE [pinot]
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz closed issue #14624: numServersQueried, responded is not set in BrokerResponse for MSQE
URL: https://github.com/apache/pinot/issues/14624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] numServersQueried, responded is not set in BrokerResponse for MSQE [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on issue #14624:
URL: https://github.com/apache/pinot/issues/14624#issuecomment-2535908835
It should be fairly straightforward to get the servers queried from the query plan in the broker. I'm not sure if there's a straightforward way to get the servers responded stats though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org