[jira] [Created] (LUCENE-8805) Parameter changes for binaryField() and stringField() in StoredFieldVisitor

["Namgyu Kim (JIRA)" <ji...@apache.org>]

Namgyu Kim created LUCENE-8805:
----------------------------------

             Summary: Parameter changes for binaryField() and stringField() in StoredFieldVisitor
                 Key: LUCENE-8805
                 URL: https://issues.apache.org/jira/browse/LUCENE-8805
             Project: Lucene - Core
          Issue Type: Improvement
            Reporter: Namgyu Kim


I wrote this patch after seeing the comments left by [~mikemccand] when SortingStoredFieldsConsumer class was first created.

{code:java}
@Override
public void binaryField(FieldInfo fieldInfo, byte[] value) throws IOException {
  ...
  // TODO: can we avoid new BR here?
  ...
}
@Override
public void stringField(FieldInfo fieldInfo, byte[] value) throws IOException {
  ...
  // TODO: can we avoid new String here?
  ...
}
{code}
I changed two things.
1) change binaryField() parameters from byte[] to BytesRef.
2) change stringField() parameters from byte[] to String.

I also changed the related contents while doing the work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org