You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2022/10/10 15:17:53 UTC

[GitHub] [bahir-flink] srmrz commented on a diff in pull request #156: Bump redis version to 4.2.9

srmrz commented on code in PR #156:
URL: https://github.com/apache/bahir-flink/pull/156#discussion_r991403682


##########
flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java:
##########
@@ -46,15 +46,7 @@ public RedisClusterContainer(JedisCluster jedisCluster) {
         this.jedisCluster = jedisCluster;
     }
 
-    @Override
-    public void open() throws Exception {
-
-        // echo() tries to open a connection and echos back the
-        // message passed as argument. Here we use it to monitor
-        // if we can communicate with the cluster.
-
-        jedisCluster.echo("Test");
-    }
+    public void open() {}

Review Comment:
   re:override, sure, let me do that!
   
   I'll take a look at the "communication test"
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org