You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/21 09:24:16 UTC

[GitHub] [cloudstack] Pearl1594 opened a new pull request #6143: api: Remove redundant API parameters

Pearl1594 opened a new pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143


   ### Description
   
   This PR removes the redundant api parameters listed under listVirtualMachines API. The parameters are already defined in `ListVMsCmdByAdmin` class
   ```
   (localcloud) 🐱 > list virtualmachines -h
   listVirtualMachines: List the virtual machines owned by the account.
   API Params               Type     Description
   ==========               ====     ===========
   account                  string   list resources by account. Must be used w
                                     ith the domainId parameter.
   ...
   hostid                   uuid     the host ID
   hostid                   uuid     the host ID
   ...
   podid                    uuid     the pod ID
   podid                    uuid     the pod ID
   ...
   storageid                uuid     the storage ID where vm's volumes belong 
                                     to
   storageid                uuid     the storage ID where vm's volumes belong 
                                     to
   ...
   ```
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [X] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073704435


   Thanks for reviewing @GabrielBrascher , the following params: pod_id, storage_id, host_id, seem to be used only applicable only for root admins - https://github.com/apache/cloudstack/blob/main/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java#L1004-L1011 , hence I took the following approach. It removes the redundant params and also ensures to behave the same way as before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073840258


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GabrielBrascher commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073711150


   Sorry @Pearl1594, I raised the question regarding  "Admins & Users".
   However, my concerns are regarding what @DaanHoogland mentioned, Admins & Domain Admins.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073770876


   It seems that only listing zones is allowed by domainAdmins - listing storage pools, hosts, clusters and pods, are restricted to root admins only. So, this change shouldn't effect any behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073833954


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2943


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073699851


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez merged pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073795373


   @Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073689691


   @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073794909


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073705963


   @Pearl1594 shouldn't a domain- or resource admin be allowed to list by host, pod, zone ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 edited a comment on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
Pearl1594 edited a comment on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073770876


   It seems that only listing zones is allowed for all roles - listing storage pools, hosts, clusters and pods, are restricted to root admins only. So, this change shouldn't effect any behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Pearl1594 commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073839305


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1079256826


   Have tested different roles and as advised by @Pearl1594 the removed parameters only apply for ROOT admin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073690636


   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2942


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1073689415


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6143: api: Remove redundant API parameters

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6143:
URL: https://github.com/apache/cloudstack/pull/6143#issuecomment-1074456387


   <b>Trillian test result (tid-3683)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31833 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6143-t3683-kvm-centos7.zip
   Smoke tests completed. 92 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org