You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by mp...@apache.org on 2023/07/10 09:40:28 UTC
[ignite-extensions] branch master updated: IGNITE-18548 Fixed flaky AbstractReplicationTest#checkMetrics test (#219)
This is an automated email from the ASF dual-hosted git repository.
mpetrov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite-extensions.git
The following commit(s) were added to refs/heads/master by this push:
new 5132de38 IGNITE-18548 Fixed flaky AbstractReplicationTest#checkMetrics test (#219)
5132de38 is described below
commit 5132de38c2543bb855ccb077c4fc5610efb4e5dd
Author: Ilya Shishkov <sh...@gmail.com>
AuthorDate: Mon Jul 10 12:40:23 2023 +0300
IGNITE-18548 Fixed flaky AbstractReplicationTest#checkMetrics test (#219)
---
.../test/java/org/apache/ignite/cdc/AbstractReplicationTest.java | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/modules/cdc-ext/src/test/java/org/apache/ignite/cdc/AbstractReplicationTest.java b/modules/cdc-ext/src/test/java/org/apache/ignite/cdc/AbstractReplicationTest.java
index 02d394d8..fb9bd0b2 100644
--- a/modules/cdc-ext/src/test/java/org/apache/ignite/cdc/AbstractReplicationTest.java
+++ b/modules/cdc-ext/src/test/java/org/apache/ignite/cdc/AbstractReplicationTest.java
@@ -584,7 +584,7 @@ public abstract class AbstractReplicationTest extends GridCommonAbstractTest {
protected abstract void checkConsumerMetrics(Function<String, Long> longMetric);
/** */
- protected void checkMetrics() {
+ protected void checkMetrics() throws IgniteInterruptedCheckedException {
for (int i = 0; i < cdcs.size(); i++) {
IgniteConfiguration cfg = getFieldValue(cdcs.get(i), "igniteCfg");
@@ -617,14 +617,15 @@ public abstract class AbstractReplicationTest extends GridCommonAbstractTest {
}
/** */
- private void checkMetrics(Function<String, Long> longMetric, Function<String, String> strMetric) {
+ private void checkMetrics(Function<String, Long> longMetric, Function<String, String> strMetric)
+ throws IgniteInterruptedCheckedException {
long committedSegIdx = longMetric.apply(COMMITTED_SEG_IDX);
long curSegIdx = longMetric.apply(CUR_SEG_IDX);
assertTrue(committedSegIdx <= curSegIdx);
assertTrue(longMetric.apply(COMMITTED_SEG_OFFSET) >= 0);
- assertTrue(longMetric.apply(LAST_SEG_CONSUMPTION_TIME) > 0);
+ assertTrue(waitForCondition(() -> longMetric.apply(LAST_SEG_CONSUMPTION_TIME) > 0, getTestTimeout()));
for (String m : new String[] {BINARY_META_DIR, MARSHALLER_DIR, CDC_DIR})
assertTrue(new File(strMetric.apply(m)).exists());