You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/05 14:48:50 UTC

[GitHub] [incubator-uniffle] frankliee commented on a diff in pull request #132: [ISSUE-48][FEATURE] Add Uniffle Dockerfile

frankliee commented on code in PR #132:
URL: https://github.com/apache/incubator-uniffle/pull/132#discussion_r938892748


##########
deploy/kubernetes/docker/Dockerfile:
##########
@@ -0,0 +1,29 @@
+FROM openjdk:8-jdk-slim

Review Comment:
   I suggest to use other general-purpose images, such as alpine or centos. 
   Many companies may have their own JDK choices, so we should treat JDK as 3rd party lib hadoop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org