You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by scottkwalker <gi...@git.apache.org> on 2017/02/23 14:23:51 UTC
[GitHub] bahir pull request #36: Fixes for akka example
GitHub user scottkwalker opened a pull request:
https://github.com/apache/bahir/pull/36
Fixes for akka example
Hi,
I was looking at the streaming-akka example in Intellij IDE and it suggested some minor fixes:
- use string interpolation
- the mutable collection must be prefixed as mutable
Best regards,
Scott
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottkwalker/bahir fixes-for-akka-example
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit bab4876857b1d732736286905b414e6ebf72f5c9
Author: Scott Walker <sc...@digital.hmrc.gov.uk>
Date: 2017-02-23T14:11:17Z
Fix legacy string formatting, an interpolated string can be used instead
commit 8407773a6a56f2dc23b821266a9b065fa4008155
Author: Scott Walker <sc...@digital.hmrc.gov.uk>
Date: 2017-02-23T14:13:12Z
LinkedHashSet must be prefixed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir pull request #36: Fixes for akka example
Posted by scottkwalker <gi...@git.apache.org>.
GitHub user scottkwalker reopened a pull request:
https://github.com/apache/bahir/pull/36
Fixes for akka example
Hi,
I was looking at the streaming-akka example in Intellij IDE and it suggested some minor fixes:
- use string interpolation
- the mutable collection must be prefixed as mutable
Best regards,
Scott
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottkwalker/bahir fixes-for-akka-example
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit bab4876857b1d732736286905b414e6ebf72f5c9
Author: Scott Walker <sc...@digital.hmrc.gov.uk>
Date: 2017-02-23T14:11:17Z
Fix legacy string formatting, an interpolated string can be used instead
commit 8407773a6a56f2dc23b821266a9b065fa4008155
Author: Scott Walker <sc...@digital.hmrc.gov.uk>
Date: 2017-02-23T14:13:12Z
LinkedHashSet must be prefixed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #36: Fixes for akka example
Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:
https://github.com/apache/bahir/pull/36
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #36: Fixes for akka example
Posted by ApacheBahir <gi...@git.apache.org>.
Github user ApacheBahir commented on the issue:
https://github.com/apache/bahir/pull/36
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir pull request #36: Fixes for akka example
Posted by scottkwalker <gi...@git.apache.org>.
Github user scottkwalker closed the pull request at:
https://github.com/apache/bahir/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #36: Fixes for akka example
Posted by ckadner <gi...@git.apache.org>.
Github user ckadner commented on the issue:
https://github.com/apache/bahir/pull/36
@scottkwalker -- thank you. LGTM. I will merge this tonight
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir pull request #36: Fixes for akka example
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bahir/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #36: Fixes for akka example
Posted by ckadner <gi...@git.apache.org>.
Github user ckadner commented on the issue:
https://github.com/apache/bahir/pull/36
@scottkwalker -- apologies for the delay, thanks for your code style fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---