You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Gert Vanthienen (JIRA)" <ji...@apache.org> on 2010/12/14 14:05:01 UTC

[jira] Created: (SMXCOMP-832) Builds should only create files in the target folder

Builds should only create files in the target folder
----------------------------------------------------

                 Key: SMXCOMP-832
                 URL: https://issues.apache.org/jira/browse/SMXCOMP-832
             Project: ServiceMix Components
          Issue Type: Task
            Reporter: Gert Vanthienen
            Priority: Minor


I've added a few extra entries to the .gitignore file for JBI components, but we probably want to alter the builds to generate these files in the {{target}} folder instead so they get cleaned up properly with a {{mvn clean}} as well.

{noformat}
# Files created outside target/ folder by builds
activemq-data
ServiceMixFlow.dot
ServiceMixComponents.dot
derby.log
bindings/servicemix-cxf-bc/data
{noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SMXCOMP-832) Builds should only create files in the target folder

Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SMXCOMP-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ioannis Canellos updated SMXCOMP-832:
-------------------------------------

    Attachment: SMXCOMP-832-patch.txt

I am attaching a patch which adds *.log and *.dot in the clean list. 

This way with the mvn clean, all test generated files are removed. I am not sure if it covers 100% our needs. If not I will contribute what was initially requested.

> Builds should only create files in the target folder
> ----------------------------------------------------
>
>                 Key: SMXCOMP-832
>                 URL: https://issues.apache.org/jira/browse/SMXCOMP-832
>             Project: ServiceMix Components
>          Issue Type: Task
>            Reporter: Gert Vanthienen
>            Priority: Minor
>         Attachments: SMXCOMP-832-patch.txt
>
>
> I've added a few extra entries to the .gitignore file for JBI components, but we probably want to alter the builds to generate these files in the {{target}} folder instead so they get cleaned up properly with a {{mvn clean}} as well.
> {noformat}
> # Files created outside target/ folder by builds
> activemq-data
> ServiceMixFlow.dot
> ServiceMixComponents.dot
> derby.log
> bindings/servicemix-cxf-bc/data
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMXCOMP-832) Builds should only create files in the target folder

Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SMXCOMP-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971758#action_12971758 ] 

Ioannis Canellos commented on SMXCOMP-832:
------------------------------------------

Some of the commonly created folders such as activemq-data and rootDir are delete with clean, because of maven-clean-plugin configuration in components-pom.

Would you prefer to add the files listed in the maven-clean-plugin configuration instead?

> Builds should only create files in the target folder
> ----------------------------------------------------
>
>                 Key: SMXCOMP-832
>                 URL: https://issues.apache.org/jira/browse/SMXCOMP-832
>             Project: ServiceMix Components
>          Issue Type: Task
>            Reporter: Gert Vanthienen
>            Priority: Minor
>
> I've added a few extra entries to the .gitignore file for JBI components, but we probably want to alter the builds to generate these files in the {{target}} folder instead so they get cleaned up properly with a {{mvn clean}} as well.
> {noformat}
> # Files created outside target/ folder by builds
> activemq-data
> ServiceMixFlow.dot
> ServiceMixComponents.dot
> derby.log
> bindings/servicemix-cxf-bc/data
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SMXCOMP-832) Builds should only create files in the target folder

Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SMXCOMP-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971860#action_12971860 ] 

Gert Vanthienen commented on SMXCOMP-832:
-----------------------------------------

Applied the patch in http://svn.apache.org/viewvc?view=revision&revision=1049725.
Thanks to Ioannis to providing this patch!

I think the patch is a very good start to ensure we get consistent build results, but we might want to try and get everything in the target folder anyway to avoid adding the same stuff to both the .gitignore file and the pom.xml file.

> Builds should only create files in the target folder
> ----------------------------------------------------
>
>                 Key: SMXCOMP-832
>                 URL: https://issues.apache.org/jira/browse/SMXCOMP-832
>             Project: ServiceMix Components
>          Issue Type: Task
>            Reporter: Gert Vanthienen
>            Priority: Minor
>         Attachments: SMXCOMP-832-patch.txt
>
>
> I've added a few extra entries to the .gitignore file for JBI components, but we probably want to alter the builds to generate these files in the {{target}} folder instead so they get cleaned up properly with a {{mvn clean}} as well.
> {noformat}
> # Files created outside target/ folder by builds
> activemq-data
> ServiceMixFlow.dot
> ServiceMixComponents.dot
> derby.log
> bindings/servicemix-cxf-bc/data
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (SMXCOMP-832) Builds should only create files in the target folder

Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SMXCOMP-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971758#action_12971758 ] 

Ioannis Canellos edited comment on SMXCOMP-832 at 12/15/10 1:00 PM:
--------------------------------------------------------------------

Some of the commonly created folders such as activemq-data and rootDir do get deleted with mvn clean, because of maven-clean-plugin configuration in components-pom.

Would you prefer to add the files listed in the maven-clean-plugin configuration instead?

      was (Author: iocanel):
    Some of the commonly created folders such as activemq-data and rootDir are delete with clean, because of maven-clean-plugin configuration in components-pom.

Would you prefer to add the files listed in the maven-clean-plugin configuration instead?
  
> Builds should only create files in the target folder
> ----------------------------------------------------
>
>                 Key: SMXCOMP-832
>                 URL: https://issues.apache.org/jira/browse/SMXCOMP-832
>             Project: ServiceMix Components
>          Issue Type: Task
>            Reporter: Gert Vanthienen
>            Priority: Minor
>
> I've added a few extra entries to the .gitignore file for JBI components, but we probably want to alter the builds to generate these files in the {{target}} folder instead so they get cleaned up properly with a {{mvn clean}} as well.
> {noformat}
> # Files created outside target/ folder by builds
> activemq-data
> ServiceMixFlow.dot
> ServiceMixComponents.dot
> derby.log
> bindings/servicemix-cxf-bc/data
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.