You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2010/02/01 21:14:18 UTC

[jira] Created: (TS-129) BIND DNS code license incompatibility

BIND DNS code license incompatibility
-------------------------------------

                 Key: TS-129
                 URL: https://issues.apache.org/jira/browse/TS-129
             Project: Traffic Server
          Issue Type: Improvement
            Reporter: Leif Hedstrom
             Fix For: 2.0.0a


We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TS-129) BIND DNS code license incompatibility

Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Call resolved TS-129.
---------------------------

    Resolution: Fixed

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-129) BIND DNS code license incompatibility

Posted by "Jason Giedymin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835350#action_12835350 ] 

Jason Giedymin commented on TS-129:
-----------------------------------

John Plevyak submitted the patch, not John Giedymin.  :-)

Thought I had a long lost cousin I've never met!

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (TS-129) BIND DNS code license incompatibility

Posted by "Jason Giedymin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832808#action_12832808 ] 

Jason Giedymin edited comment on TS-129 at 2/12/10 2:35 AM:
------------------------------------------------------------

Hope this helps,

/*
 * Resolver options (keep these in synch with res_debug.c, please)
 */
#define RES_INIT        0x00000001      /* address initialized */
#define RES_DEBUG       0x00000002      /* print debug messages */
#define RES_AAONLY      0x00000004      /* authoritative answers only (!IMPL)*/
#define RES_USEVC       0x00000008      /* use virtual circuit */
#define RES_PRIMARY     0x00000010      /* query primary server only (!IMPL) */
#define RES_IGNTC       0x00000020      /* ignore trucation errors */
#define RES_RECURSE     0x00000040      /* recursion desired */
#define RES_DEFNAMES    0x00000080      /* use default domain name */
#define RES_STAYOPEN    0x00000100      /* Keep TCP socket open */
#define RES_DNSRCH      0x00000200      /* search up local domain tree */
#define RES_INSECURE1   0x00000400      /* type 1 security disabled */
#define RES_INSECURE2   0x00000800      /* type 2 security disabled */
#define RES_NOALIASES   0x00001000      /* shuts off HOSTALIASES feature */
#define RES_USE_INET6   0x00002000      /* use/map IPv6 in gethostbyname() */
#define RES_ROTATE      0x00004000      /* rotate ns list after each query */
#define RES_NOCHECKNAME 0x00008000      /* do not check names for sanity. */
#define RES_KEEPTSIG    0x00010000      /* do not strip TSIG records */
#define RES_BLAST       0x00020000      /* blast all recursive servers */
#define RES_USEBSTRING  0x00040000      /* IPv6 reverse lookup with byte
                                           strings */
#define RES_NOIP6DOTINT 0x00080000      /* Do not use .ip6.int in IPv6
                                           reverse lookup */
#define RES_USE_EDNS0   0x00100000      /* Use EDNS0.  */
#define RES_SNGLKUP     0x00200000      /* one outstanding request at a time */
#define RES_SNGLKUPREOP 0x00400000      /* -"-, but open new socket for each
                                           request */
#define RES_USE_DNSSEC  0x00800000      /* use DNSSEC using OK bit in OPT */

#define RES_DEFAULT     (RES_RECURSE|RES_DEFNAMES|RES_DNSRCH|RES_NOIP6DOTINT)

      was (Author: jasongiedymin):
    /*
 * Resolver options (keep these in synch with res_debug.c, please)
 */
#define RES_INIT        0x00000001      /* address initialized */
#define RES_DEBUG       0x00000002      /* print debug messages */
#define RES_AAONLY      0x00000004      /* authoritative answers only (!IMPL)*/
#define RES_USEVC       0x00000008      /* use virtual circuit */
#define RES_PRIMARY     0x00000010      /* query primary server only (!IMPL) */
#define RES_IGNTC       0x00000020      /* ignore trucation errors */
#define RES_RECURSE     0x00000040      /* recursion desired */
#define RES_DEFNAMES    0x00000080      /* use default domain name */
#define RES_STAYOPEN    0x00000100      /* Keep TCP socket open */
#define RES_DNSRCH      0x00000200      /* search up local domain tree */
#define RES_INSECURE1   0x00000400      /* type 1 security disabled */
#define RES_INSECURE2   0x00000800      /* type 2 security disabled */
#define RES_NOALIASES   0x00001000      /* shuts off HOSTALIASES feature */
#define RES_USE_INET6   0x00002000      /* use/map IPv6 in gethostbyname() */
#define RES_ROTATE      0x00004000      /* rotate ns list after each query */
#define RES_NOCHECKNAME 0x00008000      /* do not check names for sanity. */
#define RES_KEEPTSIG    0x00010000      /* do not strip TSIG records */
#define RES_BLAST       0x00020000      /* blast all recursive servers */
#define RES_USEBSTRING  0x00040000      /* IPv6 reverse lookup with byte
                                           strings */
#define RES_NOIP6DOTINT 0x00080000      /* Do not use .ip6.int in IPv6
                                           reverse lookup */
#define RES_USE_EDNS0   0x00100000      /* Use EDNS0.  */
#define RES_SNGLKUP     0x00200000      /* one outstanding request at a time */
#define RES_SNGLKUPREOP 0x00400000      /* -"-, but open new socket for each
                                           request */
#define RES_USE_DNSSEC  0x00800000      /* use DNSSEC using OK bit in OPT */

#define RES_DEFAULT     (RES_RECURSE|RES_DEFNAMES|RES_DNSRCH|RES_NOIP6DOTINT)
  
> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-129) BIND DNS code license incompatibility

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828739#action_12828739 ] 

John Plevyak commented on TS-129:
---------------------------------

In discussion we decided to remove the DNS proxy.  If that is the offending code it
will resolve this issue.

Could someone attach the information about the BIND code, the files and line numbers
if possible.

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>             Fix For: 2.0.0a
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-129) BIND DNS code license incompatibility

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom updated TS-129:
-----------------------------

    Priority: Blocker  (was: Major)

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-129) BIND DNS code license incompatibility

Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835398#action_12835398 ] 

Bryan Call commented on TS-129:
-------------------------------

My bad, too bad you can't edit svn comments like git.  :(

Didn't expect 2 Johns to be commenting on the same bug, go figure.  That is what I get for doing a copy and paste...

Sorry, John *Pievyak*


> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-129) BIND DNS code license incompatibility

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832631#action_12832631 ] 

John Plevyak commented on TS-129:
---------------------------------

gack,could you post here the chunk of /usr/include/resolve.h which contains the definitions for resolver
options including RES_USE_DNSSEC so I can see if you just have a newer version of BIND or if 
linux is diverging.

one possible solution is to just convert these to INK_RES_XXX in our code... comment?

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-129) BIND DNS code license incompatibility

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Plevyak updated TS-129:
----------------------------

    Attachment: ts-bind-jp-v2.patch

This includes the patch for TS-44.  Pulled in BIND code for that as well
as I already had all the license headers setup.

Please review.

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-129) BIND DNS code license incompatibility

Posted by "George Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830995#action_12830995 ] 

George Paul commented on TS-129:
--------------------------------

New changes look good. Tested patch and DNS regressions passed.
-George

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-129) BIND DNS code license incompatibility

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833169#action_12833169 ] 

John Plevyak commented on TS-129:
---------------------------------

I agree on the TS_ prefix but I would like us to vote on it and then do the change with perl all at once. 
If we switch to TS_ and then the vote comes out ATS_ or something then it would make it more difficult
to do the change globally.

I would like to just check this in and clear the blocker and then call for a vote on the new prefix separately....

Bryan, do you want to call for a vote on TS_ ... ? I'll give it a +1

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-129) BIND DNS code license incompatibility

Posted by "Jason Giedymin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832808#action_12832808 ] 

Jason Giedymin commented on TS-129:
-----------------------------------

/*
 * Resolver options (keep these in synch with res_debug.c, please)
 */
#define RES_INIT        0x00000001      /* address initialized */
#define RES_DEBUG       0x00000002      /* print debug messages */
#define RES_AAONLY      0x00000004      /* authoritative answers only (!IMPL)*/
#define RES_USEVC       0x00000008      /* use virtual circuit */
#define RES_PRIMARY     0x00000010      /* query primary server only (!IMPL) */
#define RES_IGNTC       0x00000020      /* ignore trucation errors */
#define RES_RECURSE     0x00000040      /* recursion desired */
#define RES_DEFNAMES    0x00000080      /* use default domain name */
#define RES_STAYOPEN    0x00000100      /* Keep TCP socket open */
#define RES_DNSRCH      0x00000200      /* search up local domain tree */
#define RES_INSECURE1   0x00000400      /* type 1 security disabled */
#define RES_INSECURE2   0x00000800      /* type 2 security disabled */
#define RES_NOALIASES   0x00001000      /* shuts off HOSTALIASES feature */
#define RES_USE_INET6   0x00002000      /* use/map IPv6 in gethostbyname() */
#define RES_ROTATE      0x00004000      /* rotate ns list after each query */
#define RES_NOCHECKNAME 0x00008000      /* do not check names for sanity. */
#define RES_KEEPTSIG    0x00010000      /* do not strip TSIG records */
#define RES_BLAST       0x00020000      /* blast all recursive servers */
#define RES_USEBSTRING  0x00040000      /* IPv6 reverse lookup with byte
                                           strings */
#define RES_NOIP6DOTINT 0x00080000      /* Do not use .ip6.int in IPv6
                                           reverse lookup */
#define RES_USE_EDNS0   0x00100000      /* Use EDNS0.  */
#define RES_SNGLKUP     0x00200000      /* one outstanding request at a time */
#define RES_SNGLKUPREOP 0x00400000      /* -"-, but open new socket for each
                                           request */
#define RES_USE_DNSSEC  0x00800000      /* use DNSSEC using OK bit in OPT */

#define RES_DEFAULT     (RES_RECURSE|RES_DEFNAMES|RES_DNSRCH|RES_NOIP6DOTINT)

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-129) BIND DNS code license incompatibility

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Plevyak updated TS-129:
----------------------------

    Attachment: ts-bind-jp-v1.patch

Here is a patch to fix this by moving to the current stable BIND code
with the new BSD license.  I had to hack the code a bit, in particular
the round-robin DNS code needed some help.

Please review these changes as I an not familar with the
RR or SplitDNS code.

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-129) BIND DNS code license incompatibility

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833071#action_12833071 ] 

John Plevyak commented on TS-129:
---------------------------------

OK, looks like glib has decided to significantly diverge from 9.6 and
bind 9.7 seems to be leaving the OS resolver code out, so I am going
to make these INK_RES_XXXXX in our code.

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (TS-129) BIND DNS code license incompatibility

Posted by "Jason Giedymin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832802#action_12832802 ] 

Jason Giedymin edited comment on TS-129 at 2/12/10 2:29 AM:
------------------------------------------------------------

Can confirm this happens on Fedora 12 i386 (32bit).

      was (Author: jasongiedymin):
    Can confirm this happens on Fedora 12 x86 (32bit).
  
> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-129) BIND DNS code license incompatibility

Posted by "Jason Giedymin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832802#action_12832802 ] 

Jason Giedymin commented on TS-129:
-----------------------------------

Can confirm this happens on Fedora 12 x86 (32bit).

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (TS-129) BIND DNS code license incompatibility

Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832312#action_12832312 ] 

Bryan Call edited comment on TS-129 at 2/11/10 12:09 AM:
---------------------------------------------------------

On Fedora 12 x86_64:

In file included from inktomi++.h:106,
                 from Allocator.cc:32:
ink_resolver.h:80:1: error: "RES_USE_DNSSEC" redefined
In file included from ink_platform.h:143,
                 from ink_error.h:36,
                 from inktomi++.h:88,
                 from Allocator.cc:32:
/usr/include/resolv.h:221:1: error: this is the location of the previous definition

ink_resolver.h:80
#define RES_USE_DNSSEC 0x00200000 

/usr/include/resolv.h:221
#define RES_USE_DNSSEC  0x00800000      /* use DNSSEC using OK bit in OPT */


      was (Author: bcall):
    In file included from inktomi++.h:106,
                 from Allocator.cc:32:
ink_resolver.h:80:1: error: "RES_USE_DNSSEC" redefined
In file included from ink_platform.h:143,
                 from ink_error.h:36,
                 from inktomi++.h:88,
                 from Allocator.cc:32:
/usr/include/resolv.h:221:1: error: this is the location of the previous definition

ink_resolver.h:80
#define RES_USE_DNSSEC 0x00200000 

/usr/include/resolv.h:221
#define RES_USE_DNSSEC  0x00800000      /* use DNSSEC using OK bit in OPT */

  
> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-129) BIND DNS code license incompatibility

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Plevyak updated TS-129:
----------------------------

    Attachment: ts-bind-jp-v2.1.patch

This converts all the internal constants to use INK_ as a prefix.

Please verify on effected systems and comment before I checkin.

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (TS-129) BIND DNS code license incompatibility

Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Call reopened TS-129:
---------------------------


In file included from inktomi++.h:106,
                 from Allocator.cc:32:
ink_resolver.h:80:1: error: "RES_USE_DNSSEC" redefined
In file included from ink_platform.h:143,
                 from ink_error.h:36,
                 from inktomi++.h:88,
                 from Allocator.cc:32:
/usr/include/resolv.h:221:1: error: this is the location of the previous definition

ink_resolver.h:80
#define RES_USE_DNSSEC 0x00200000 

/usr/include/resolv.h:221
#define RES_USE_DNSSEC  0x00800000      /* use DNSSEC using OK bit in OPT */


> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TS-129) BIND DNS code license incompatibility

Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom reassigned TS-129:
--------------------------------

    Assignee: John Plevyak

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TS-129) BIND DNS code license incompatibility

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Plevyak resolved TS-129.
-----------------------------

    Resolution: Fixed

Committed revision 907756.


> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-129) BIND DNS code license incompatibility

Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833086#action_12833086 ] 

Bryan Call commented on TS-129:
-------------------------------

The latest patch fixed the problems on Fedora 12 x86_64.  I recommend that we start to use the prefix TS_ for everything instead of INK_.  At some point we will need to change everything over.

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch, ts-bind-jp-v2.1.patch, ts-bind-jp-v2.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-129) BIND DNS code license incompatibility

Posted by "George Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829939#action_12829939 ] 

George Paul commented on TS-129:
--------------------------------

Code patch looks fine AFAICT. Tested patch and ran the simple DNS regression which passed. At some point simple regression tests for RR and splitDNS code paths should be added.

Could the BSD versions of the code for TS-44 functions be added in this patch since they are related to 'iocore/DNS.cc' changes. As is mentioned in that ticket there is BSD code for the necessary functions here:

 http://fxr.watson.org/fxr/source/nameser/ns_name.c?v=FREEBSD-LIBC
 http://fxr.watson.org/fxr/source/nameser/ns_netint.c?v=FREEBSD-LIBC

Also instead of pulling in ns_get16() could use the NS_GET16 macros in 'ink_resolver.h'

-George

> BIND DNS code license incompatibility
> -------------------------------------
>
>                 Key: TS-129
>                 URL: https://issues.apache.org/jira/browse/TS-129
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Leif Hedstrom
>            Assignee: John Plevyak
>            Priority: Blocker
>             Fix For: 2.0.0a
>
>         Attachments: ts-bind-jp-v1.patch
>
>
> We have some BIND related code in TS, which we need to replace with something that is ASL compatible. Or, as discussed, if this code is for DNS proxy only, lets just remove it and disable DNS proxying for now at least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.