You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/13 18:50:20 UTC
[GitHub] [iceberg] jackye1995 opened a new issue #3895: Clarify usage of ValidationException vs IllegalArgumentException
jackye1995 opened a new issue #3895:
URL: https://github.com/apache/iceberg/issues/3895
based on https://github.com/apache/iceberg/pull/3104#discussion_r780844208
I did not have a good way to distinguish what exception to use for what case, the definition provided by Ryan was clear. I think we should add that in the javadoc of `ValidationException` class about when to use it and when to use `Preconditions` to throw illegal argument exception.
This will give more clarity to both implementer and reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] sanyud24 commented on issue #3895: Clarify usage of ValidationException vs IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
sanyud24 commented on issue #3895:
URL: https://github.com/apache/iceberg/issues/3895#issuecomment-1014538766
May I work on this issue @jackye1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] molsionmo commented on issue #3895: Clarify usage of ValidationException vs IllegalArgumentException
Posted by GitBox <gi...@apache.org>.
molsionmo commented on issue #3895:
URL: https://github.com/apache/iceberg/issues/3895#issuecomment-1081407723
Is it over?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org