You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bzz <gi...@git.apache.org> on 2015/06/13 08:14:10 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-105 Speedup default buil...
GitHub user bzz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/101
ZEPPELIN-105 Speedup default build
Details in [ZEPPELIN-105](https://issues.apache.org/jira/browse/ZEPPELIN-105)
This PR cuts default Java projects build time ~2 times.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bzz/incubator-zeppelin build-speedup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #101
----
commit 5d1b54f886f376d0014ed58e002718cd567a2876
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-06-13T06:07:09Z
ZEPPELIN-105: move test coverage report to install phase
commit 819ff01714a9f4558e5f268841eee02ed46c789b
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2015-06-13T06:11:51Z
ZEPPELIN-105: move checkstyle violation report to install phase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-105 Speedup default buil...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/101#issuecomment-112694660
I have tested without zeppelin-web and zeppelin-distribution and my result is
From
```
$ time mvn package -DskipTests -pl '!zeppelin-web,!zeppelin-distribution'
[INFO] Total time: 01:32 min
[INFO] Finished at: 2015-06-17T00:34:53-07:00
[INFO] Final Memory: 50M/522M
[INFO] ------------------------------------------------------------------------
real 1m35.235s
user 2m36.430s
sys 0m8.422s
```
to
```
[INFO] Total time: 44.496 s
[INFO] Finished at: 2015-06-17T00:36:52-07:00
[INFO] Final Memory: 37M/501M
[INFO] ------------------------------------------------------------------------
real 0m46.687s
user 1m12.755s
sys 0m3.199s
```
Looks really good. +1 for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-105 Speedup default buil...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-105 Speedup default buil...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/101#issuecomment-112621997
Ready to be merged
\\cc @Leemoonsoo @anthonycorbacho @jongyoul for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-105 Speedup default buil...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/101#issuecomment-112733552
I tested it again as same as moon's command
From
```
$ time mvn clean install -DskipTests -pl '!zeppelin-web,!zeppelin-distribution'
[INFO] Total time: 01:21 min
[INFO] Finished at: 2015-06-17T18:19:18+09:00
[INFO] Final Memory: 130M/1758M
[INFO] ------------------------------------------------------------------------
real 1m23.240s
user 2m15.990s
sys 0m7.428s
```
To
```
$ time mvn clean package -DskipTests -pl '!zeppelin-web,!zeppelin-distribution'
[INFO] Total time: 43.344 s
[INFO] Finished at: 2015-06-17T18:22:39+09:00
[INFO] Final Memory: 110M/1478M
[INFO] ------------------------------------------------------------------------
real 0m45.127s
user 1m17.309s
sys 0m4.092s
```
LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-105 Speedup default buil...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/101#issuecomment-112661142
In my case,
From,
```
$ time mvn clean install -DskipTests
[INFO] Total time: 01:44 min
[INFO] Finished at: 2015-06-17T14:30:13+09:00
[INFO] Final Memory: 127M/1683M
[INFO] ------------------------------------------------------------------------
real 1m46.327s
user 2m41.117s
sys 0m8.931s
```
To,
```
$ time mvn package install -DskipTests
[INFO] Total time: 01:09 min
[INFO] Finished at: 2015-06-17T14:37:42+09:00
[INFO] Final Memory: 113M/1456M
[INFO] ------------------------------------------------------------------------
real 1m11.303s
user 1m40.283s
sys 0m5.623s
```
Npm packages are already installed both cases. It helps me more when codes are bigger.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-105 Speedup default buil...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/101#issuecomment-112691575
@jongyoul thanks for checking out!
as I say in description ' cuts *Java projects* build time ~2 times'.
All the measurements from above are without building `zeppelin-web` as this is subject of separate, non-maven optimizations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---