You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/13 03:10:09 UTC

[GitHub] [dubbo-go-samples] xiaoliu10 commented on a change in pull request #22: modify consul demo to support makefile

xiaoliu10 commented on a change in pull request #22:
URL: https://github.com/apache/dubbo-go-samples/pull/22#discussion_r541831078



##########
File path: registry/servicediscovery/consul/go-client/pkg/user.go
##########
@@ -15,25 +15,13 @@
  * limitations under the License.
  */
 
-package main
+package pkg

Review comment:
       all samples use pkg ,  so do i




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org