[GitHub] [cassandra] ekaterinadimitrova2 commented on pull request #1904: Enable dtest-offheap in CircleCI

[GitBox <gi...@apache.org>]

ekaterinadimitrova2 commented on PR #1904:
URL: https://github.com/apache/cassandra/pull/1904#issuecomment-1283287493

   Thank you for your work. There are a few things here which we need to work out:
   1) Adding new jobs requires recreating the patches. (as per the instructions in the readme). Even if the patch applies, it might be moving things to different lines. If you try now to run `.circleci/generate.sh -m` you get:
   ```
   Generating new config.yml file with middle resources from config-2_1.yml
   patching file .circleci/config-2_1.yml
   Hunk #1 succeeded at 111 (offset 6 lines).
   Hunk #2 succeeded at 126 (offset 6 lines).
   Hunk #3 succeeded at 168 (offset 6 lines).
   Hunk #4 succeeded at 931 (offset 34 lines).
   Hunk #5 succeeded at 945 with fuzz 1 (offset 34 lines).
   Hunk #6 succeeded at 960 with fuzz 1 (offset 34 lines).
   Hunk #7 succeeded at 974 (offset 34 lines).
   Hunk #8 succeeded at 989 (offset 34 lines).
   Hunk #9 succeeded at 1003 (offset 34 lines).
   Hunk #10 succeeded at 1018 (offset 34 lines).
   Hunk #11 succeeded at 1036 (offset 34 lines).
   Hunk #12 succeeded at 1051 (offset 34 lines).
   Hunk #13 succeeded at 1069 (offset 34 lines).
   Hunk #14 succeeded at 1084 (offset 34 lines).
   Hunk #15 succeeded at 1102 (offset 34 lines).
   Hunk #16 succeeded at 1117 (offset 34 lines).
   ```
   
   I just tried the following to regenerate the patches on your branch:
   
   # apply old patches (with hunk messages)
   patch -o config-2_1.yml.MIDRES config-2_1.yml config-2_1.yml.mid_res.patch
   patch -o config-2_1.yml.HIGHRES config-2_1.yml config-2_1.yml.high_res.patch
   
   # generate new patches
   diff -u config-2_1.yml config-2_1.yml.HIGHRES > config-2_1.yml.high_res.patch
   diff -u config-2_1.yml config-2_1.yml.MIDRES > config-2_1.yml.mid_res.patch
   
   # verify that the new patches generate the same files and cleanup
   ./generate.sh -a"
   
   This actually created some diff which was missing and it shows me that the update was not accurately done. (The parameter from the commit which is still not removed popped up now)
   
   All in all the main goal is to ensure that when we apply the patches they create MIDRES and HIGHRES with all resources assigned to the old jobs as they were and adds a new job with the resources we want. 
   
   2) How were the midres resources chosen? Is there a CI run? I guess you just used the same resources as the regular dtests jobs which we have already? I would probably start from there too, but we need also to test. Do you have a paid account to run them or do you need help?
   
   3) This is trunk, I thought we aim to align all branches? In this case those tests run in Jenkins on 3.11+
   Normally we start creating patches on the lowest C* version we target branch and propagate up to trunk. You might want to check the Development section on our web site. 
   
   4) Agreed with @michaelsembwever, the second commit deserves its own ticket and commit
   
   3) Andres committed today a patch that adds repeated jobs pre-commit, detection of changed/added new tests. You will need to rebase and figure out how your patch is affected. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org