You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/06/09 06:40:41 UTC
[GitHub] [calcite] zhztheplayer commented on a change in pull request #1262:
[CALCITE-2804] fix broken unit test
zhztheplayer commented on a change in pull request #1262: [CALCITE-2804] fix broken unit test
URL: https://github.com/apache/calcite/pull/1262#discussion_r291828611
##########
File path: druid/src/test/java/org/apache/calcite/test/DruidAdapterIT.java
##########
@@ -577,23 +577,28 @@ protected boolean enabled() {
*/
@Test public void testCastToTimestamp() {
final String sql = "select cast(\"timestamp\" as timestamp) from \"foodmart\"";
- final String druidQuery = "{'queryType':'scan','dataSource':'foodmart',"
- + "'intervals':['1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z']',"
- + "'virtualColumns:[{'type':'expression','name':'vc',"
- + "'expression':'timestamp_parse("
- + "timestamp_format(\"__time\",'yyyy-MM-dd\\u0027T\\u0027HH:mm:ss.SSS\\u0027Z\\u0027',"
- + "'America/New_York'),'yyyy-MM-dd\\u0027T\\u0027HH:mm:ss.SSS\\u0027Z\\u0027','UTC')',"
- + "'outputType':'LONG'}],"
- + "'columns':['vc'],"
- + "'resultFormat':'compactedList'}";
+ final String druidQuery = "{\"queryType\":\"scan\",\"dataSource\":\"foodmart\","
+ + "\"intervals\":[\"1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z\"],"
+ + "\"virtualColumns\":[{\"type\":\"expression\",\"name\":\"vc\","
+ + "\"expression\":\"timestamp_parse("
+ + "timestamp_format(\\\"__time\\\",'yyyy-MM-dd\\\\u0027T\\\\u0027HH:mm:ss.SSS\\\\u0027Z\\\\u0027',"
+ + "'America/New_York'),'yyyy-MM-dd\\\\u0027T\\\\u0027HH:mm:ss.SSS\\\\u0027Z\\\\u0027','UTC')\","
+ + "\"outputType\":\"LONG\"}],"
+ + "\"columns\":[\"vc\"],"
+ + "\"resultFormat\":\"compactedList\"}";
CalciteAssert.that()
.enable(enabled())
Review comment:
Here we have 5 spaces :(, but we use 4 spaces for continuous indention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services