You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com> on 2016/02/25 19:53:24 UTC
Review Request 44031: HIVE-13130: API calls for retrieving primary
keys and foreign keys information
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44031/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files.
Diffs
-----
jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f
metastore/if/hive_metastore.thrift e8f0a68
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java bfebfdc
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java b5c4d1d
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cb092d1
service-rpc/if/TCLIService.thrift 0aa9d13
service/src/java/org/apache/hive/service/cli/CLIService.java cc6e138
service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be
service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd
service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18
service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 4aa1875
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java a81c600
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff264
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165
Diff: https://reviews.apache.org/r/44031/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan
Re: Review Request 44031: HIVE-13130: HS2 changes: API calls for
retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44031/
-----------------------------------------------------------
(Updated April 19, 2016, 8:50 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
HS2 changes: API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files.
Diffs (updated)
-----
jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f
service-rpc/if/TCLIService.thrift aa28b6e
service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2
service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be
service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd
service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18
service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 0f36cd6
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 14191e5
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java e789a38
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java ccce6dc
Diff: https://reviews.apache.org/r/44031/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan
Re: Review Request 44031: HIVE-13130: HS2 changes: API calls for
retrieving primary keys and foreign keys information
Posted by Carl Steinbach <cw...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44031/#review126757
-----------------------------------------------------------
service-rpc/if/TCLIService.thrift (line 958)
<https://reviews.apache.org/r/44031/#comment189824>
Please add doc comments for the two new *Req types (TGetFunctionsReq is a good example). If the behavior is expected to match the corresponding JDBC calls, please state so in the comment.
- Carl Steinbach
On March 29, 2016, 12:11 a.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44031/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 12:11 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HS2 changes: API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files.
>
>
> Diffs
> -----
>
> jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f
> service-rpc/if/TCLIService.thrift aa28b6e
> service-rpc/src/gen/thrift/gen-cpp/TCLIService.h 3407564
> service-rpc/src/gen/thrift/gen-cpp/TCLIService.cpp fc82b88
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 66ed6a7
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 7f1d9dd
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 3a27a60
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java c684f89
> service-rpc/src/gen/thrift/gen-php/TCLIService.php eba62f1
> service-rpc/src/gen/thrift/gen-php/Types.php b7df50a
> service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 56f5c5d
> service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService.py ad2d71d
> service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py c691781
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service.rb 7d7f7a7
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 07ed97c
> service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2
> service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be
> service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd
> service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18
> service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 80a1844
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 14191e5
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 62fcde5
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java ccce6dc
>
> Diff: https://reviews.apache.org/r/44031/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 44031: HIVE-13130: HS2 changes: API calls for
retrieving primary keys and foreign keys information
Posted by Carl Steinbach <cw...@apache.org>.
> On April 6, 2016, 8:53 p.m., Ashutosh Chauhan wrote:
> > service-rpc/if/TCLIService.thrift, line 963
> > <https://reviews.apache.org/r/44031/diff/2/?file=1317342#file1317342line963>
> >
> > Do we really need catalogName? In Hive, there is no concept of Catalog at the moment.
I disagree with Ashutosh. Consider the following points:
1) Whenever possible the HS2 Thrift API tries to maintain a 1:1 mapping with the corresponding JDBC API methods.
2) The getSchemas(), getTables(), getColumns() and getFunctions() methods in the JDBC API all take a catalogName field as input. As a result the getSchemas(), getTables(), getColumns() and getFunctions() methods in the HS2 JDBC driver also take a catalogName field as input. So far this hasn't caused any problems.
3) The GetSchemas(), GetTables(), GetColumns() and GetFunctions() RPCs in the HS2 Thrift API have catalogName input parameters. Since this hasn't caused any problems I don't know why we would want to break this convention now.
Please do not remove catalogName from any of these RPCs.
> On April 6, 2016, 8:53 p.m., Ashutosh Chauhan wrote:
> > service-rpc/if/TCLIService.thrift, line 966
> > <https://reviews.apache.org/r/44031/diff/2/?file=1317342#file1317342line966>
> >
> > Its better to call this dbName to be consistent with Hive terminology.
No, it's better to use schemaName to be consistent with JDBC terminology, as well as to maintain consistency with the other RPCs that are already part of this Thrift API.
> On April 6, 2016, 8:53 p.m., Ashutosh Chauhan wrote:
> > service-rpc/if/TCLIService.thrift, line 974
> > <https://reviews.apache.org/r/44031/diff/2/?file=1317342#file1317342line974>
> >
> > Why is this optional?
There won't be an operationHandle to return if the status indicates an error. Consider what happens when getPrimaryKeys() throws a SQLException instead of returning a ResultSet.
> On April 6, 2016, 8:53 p.m., Ashutosh Chauhan wrote:
> > service-rpc/if/TCLIService.thrift, line 985
> > <https://reviews.apache.org/r/44031/diff/2/?file=1317342#file1317342line985>
> >
> > Database
No.
> On April 6, 2016, 8:53 p.m., Ashutosh Chauhan wrote:
> > service-rpc/if/TCLIService.thrift, line 982
> > <https://reviews.apache.org/r/44031/diff/2/?file=1317342#file1317342line982>
> >
> > There is no catalog in Hive.
Ignore.
- Carl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44031/#review127434
-----------------------------------------------------------
On March 29, 2016, 12:11 a.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44031/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 12:11 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HS2 changes: API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files.
>
>
> Diffs
> -----
>
> jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f
> service-rpc/if/TCLIService.thrift aa28b6e
> service-rpc/src/gen/thrift/gen-cpp/TCLIService.h 3407564
> service-rpc/src/gen/thrift/gen-cpp/TCLIService.cpp fc82b88
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 66ed6a7
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 7f1d9dd
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 3a27a60
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java c684f89
> service-rpc/src/gen/thrift/gen-php/TCLIService.php eba62f1
> service-rpc/src/gen/thrift/gen-php/Types.php b7df50a
> service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 56f5c5d
> service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService.py ad2d71d
> service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py c691781
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service.rb 7d7f7a7
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 07ed97c
> service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2
> service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be
> service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd
> service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18
> service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 80a1844
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 14191e5
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 62fcde5
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java ccce6dc
>
> Diff: https://reviews.apache.org/r/44031/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 44031: HIVE-13130: HS2 changes: API calls for
retrieving primary keys and foreign keys information
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44031/#review127434
-----------------------------------------------------------
service-rpc/if/TCLIService.thrift (line 963)
<https://reviews.apache.org/r/44031/#comment190751>
Do we really need catalogName? In Hive, there is no concept of Catalog at the moment.
service-rpc/if/TCLIService.thrift (line 966)
<https://reviews.apache.org/r/44031/#comment190752>
Its better to call this dbName to be consistent with Hive terminology.
service-rpc/if/TCLIService.thrift (line 969)
<https://reviews.apache.org/r/44031/#comment190756>
Tablename can't be optional.
service-rpc/if/TCLIService.thrift (line 974)
<https://reviews.apache.org/r/44031/#comment190757>
Why is this optional?
service-rpc/if/TCLIService.thrift (line 982)
<https://reviews.apache.org/r/44031/#comment190760>
There is no catalog in Hive.
service-rpc/if/TCLIService.thrift (line 985)
<https://reviews.apache.org/r/44031/#comment190761>
Database
- Ashutosh Chauhan
On March 29, 2016, 12:11 a.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44031/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 12:11 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HS2 changes: API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files.
>
>
> Diffs
> -----
>
> jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f
> service-rpc/if/TCLIService.thrift aa28b6e
> service-rpc/src/gen/thrift/gen-cpp/TCLIService.h 3407564
> service-rpc/src/gen/thrift/gen-cpp/TCLIService.cpp fc82b88
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 66ed6a7
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 7f1d9dd
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 3a27a60
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java c684f89
> service-rpc/src/gen/thrift/gen-php/TCLIService.php eba62f1
> service-rpc/src/gen/thrift/gen-php/Types.php b7df50a
> service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 56f5c5d
> service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService.py ad2d71d
> service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py c691781
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service.rb 7d7f7a7
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 07ed97c
> service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2
> service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be
> service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd
> service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18
> service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 80a1844
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 14191e5
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 62fcde5
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java ccce6dc
>
> Diff: https://reviews.apache.org/r/44031/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 44031: HIVE-13130: HS2 changes: API calls for
retrieving primary keys and foreign keys information
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44031/#review127621
-----------------------------------------------------------
service-rpc/if/TCLIService.thrift (line 963)
<https://reviews.apache.org/r/44031/#comment191008>
Agree about keeping this call consistent with other api calls, and retaining catalogName. Keeping HS2 away from hive specific changes will help with its re-use across other projects. Spark already has fork of HS2 code, and some committers have expressed interest in moving to a refactored HS2 that enables reuse.
- Thejas Nair
On March 29, 2016, 12:11 a.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44031/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 12:11 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HS2 changes: API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files.
>
>
> Diffs
> -----
>
> jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f
> service-rpc/if/TCLIService.thrift aa28b6e
> service-rpc/src/gen/thrift/gen-cpp/TCLIService.h 3407564
> service-rpc/src/gen/thrift/gen-cpp/TCLIService.cpp fc82b88
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 66ed6a7
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 7f1d9dd
> service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 3a27a60
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java c684f89
> service-rpc/src/gen/thrift/gen-php/TCLIService.php eba62f1
> service-rpc/src/gen/thrift/gen-php/Types.php b7df50a
> service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 56f5c5d
> service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService.py ad2d71d
> service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py c691781
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service.rb 7d7f7a7
> service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 07ed97c
> service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2
> service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be
> service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd
> service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18
> service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 80a1844
> service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 14191e5
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 62fcde5
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java ccce6dc
>
> Diff: https://reviews.apache.org/r/44031/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 44031: HIVE-13130: HS2 changes: API calls for
retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44031/
-----------------------------------------------------------
(Updated March 29, 2016, 12:11 a.m.)
Review request for hive and Ashutosh Chauhan.
Summary (updated)
-----------------
HIVE-13130: HS2 changes: API calls for retrieving primary keys and foreign keys information
Repository: hive-git
Description (updated)
-------
HS2 changes: API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files.
Diffs
-----
jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f
service-rpc/if/TCLIService.thrift aa28b6e
service-rpc/src/gen/thrift/gen-cpp/TCLIService.h 3407564
service-rpc/src/gen/thrift/gen-cpp/TCLIService.cpp fc82b88
service-rpc/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 66ed6a7
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 7f1d9dd
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 3a27a60
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java c684f89
service-rpc/src/gen/thrift/gen-php/TCLIService.php eba62f1
service-rpc/src/gen/thrift/gen-php/Types.php b7df50a
service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 56f5c5d
service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService.py ad2d71d
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py c691781
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service.rb 7d7f7a7
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 07ed97c
service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2
service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be
service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd
service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18
service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 80a1844
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 14191e5
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 62fcde5
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java ccce6dc
Diff: https://reviews.apache.org/r/44031/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan
Re: Review Request 44031: HIVE-13130: API calls for retrieving
primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44031/
-----------------------------------------------------------
(Updated March 29, 2016, 12:10 a.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
Just the JDBC/HS2 related changes.
Repository: hive-git
Description
-------
API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files.
Diffs (updated)
-----
jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f
service-rpc/if/TCLIService.thrift aa28b6e
service-rpc/src/gen/thrift/gen-cpp/TCLIService.h 3407564
service-rpc/src/gen/thrift/gen-cpp/TCLIService.cpp fc82b88
service-rpc/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 66ed6a7
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 7f1d9dd
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 3a27a60
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java c684f89
service-rpc/src/gen/thrift/gen-php/TCLIService.php eba62f1
service-rpc/src/gen/thrift/gen-php/Types.php b7df50a
service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 56f5c5d
service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService.py ad2d71d
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py c691781
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service.rb 7d7f7a7
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 07ed97c
service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2
service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be
service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd
service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18
service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 80a1844
service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 14191e5
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 62fcde5
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java ccce6dc
Diff: https://reviews.apache.org/r/44031/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan