You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by SomaticIT <gi...@git.apache.org> on 2014/07/11 21:58:15 UTC

[GitHub] cordova-plugin-inappbrowser pull request: CB-5109 - Windows 8 and ...

GitHub user SomaticIT opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/52

    CB-5109 - Windows 8 and 8.1 - InAppBrowser implementation

    In Windows 8.1, there is a new WebView control.
    It can be used to create an InAppBrowser implementation.
    
    http://msdn.microsoft.com/en-us/library/windows/apps/dn301831.aspx
    
    In order to meet the new ambitions about Windows code reunification, I centralized the Windows 8 and 8.1 version Inside the same proxy (located in src/windows/InAppBrowserProxy.js).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Touchit/cordova-plugin-inappbrowser CB-5109

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #52
    
----
commit ef9ca5ad3ee121efb22f0dfceef6628805ff0c49
Author: SomaticIT <co...@somatic.fr>
Date:   2013-10-17T21:01:13Z

    Append Windows 8.1 proxy using x-ms-webview

commit 863386398e6e595f103d593ab72c91712fcc373a
Author: SomaticIT <co...@somatic.fr>
Date:   2013-10-17T21:02:59Z

    Append Windows 8.1 platform configuration in plugin.xml

commit e5d07f14e8419dea67ec6c13d9f18a096f20a939
Author: SomaticIT <co...@somatic.fr>
Date:   2014-07-11T15:05:24Z

    Update code from remote apache repository

commit 225bde271b03b39ab6bb6bac807bfae1d960f721
Author: SomaticIT <co...@somatic.fr>
Date:   2014-07-11T15:06:39Z

    Rename windows81 by windows8 in src directory

commit ac9c64964e17e66075c8b9170a61916b5ac01acb
Author: SomaticIT <co...@somatic.fr>
Date:   2014-07-11T19:43:37Z

    Update windows proxy to be both compatible with windows 8 and 8.1

commit ea6a4fc80a2bc5b1cc74964e921df8b367e5876f
Author: SomaticIT <co...@somatic.fr>
Date:   2014-07-11T19:48:21Z

    Update doc to add Windows 8

commit 6e38667320cda5f5c199a5d6a038a001be491bdd
Author: SomaticIT <co...@somatic.fr>
Date:   2014-07-11T19:48:31Z

    Update french translation

commit d828197de45f724ad41135c3ca8f0767a0990582
Author: SomaticIT <co...@somatic.fr>
Date:   2014-07-11T19:54:25Z

    Clean plugin.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: CB-5109 - Windows 8 and ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/52


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: CB-5109 - Windows 8 and ...

Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/52#issuecomment-52083011
  
    @SomaticIT : why did you do this:
    `0  www/inappbrowser.js → www/InAppBrowser.js`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---