You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/06/06 20:50:07 UTC

[Impala-ASF-CR](2.x) Fix Indents from IMPALA-4970 

Hello Sailesh Mukil,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10622

to review the following change.


Change subject: Fix Indents from IMPALA-4970
......................................................................

Fix Indents from IMPALA-4970

fixing the mistake in indentation made previously

Change-Id: I4ea53e0780cca9f791808c2a73c7f72ba27c2159
Reviewed-on: http://gerrit.cloudera.org:8080/10560
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M be/src/runtime/coordinator.cc
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/10622/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ea53e0780cca9f791808c2a73c7f72ba27c2159
Gerrit-Change-Number: 10622
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Rahul Shivu Mahadev <ra...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR](2.x) Fix Indents from IMPALA-4970

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10622 )

Change subject: Fix Indents from IMPALA-4970
......................................................................


Patch Set 1: Verified+1

Verified with https://gerrit.cloudera.org/#/c/10623/


-- 
To view, visit http://gerrit.cloudera.org:8080/10622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ea53e0780cca9f791808c2a73c7f72ba27c2159
Gerrit-Change-Number: 10622
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Rahul Shivu Mahadev <ra...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jun 2018 00:23:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) Fix Indents from IMPALA-4970

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10622 )

Change subject: Fix Indents from IMPALA-4970
......................................................................


Patch Set 1: Code-Review+2

Clean pick


-- 
To view, visit http://gerrit.cloudera.org:8080/10622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ea53e0780cca9f791808c2a73c7f72ba27c2159
Gerrit-Change-Number: 10622
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Rahul Shivu Mahadev <ra...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 21:06:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](2.x) Fix Indents from IMPALA-4970

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10622 )

Change subject: Fix Indents from IMPALA-4970
......................................................................

Fix Indents from IMPALA-4970

fixing the mistake in indentation made previously

Change-Id: I4ea53e0780cca9f791808c2a73c7f72ba27c2159
Reviewed-on: http://gerrit.cloudera.org:8080/10560
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/10622
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M be/src/runtime/coordinator.cc
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ea53e0780cca9f791808c2a73c7f72ba27c2159
Gerrit-Change-Number: 10622
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Rahul Shivu Mahadev <ra...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>