You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/02/28 01:31:21 UTC

[PR] Add additional protobuf tests for [datafusion]

alamb opened a new pull request, #14924:
URL: https://github.com/apache/datafusion/pull/14924

   ## Which issue does this PR close?
   
   
   - Part of https://github.com/apache/datafusion/issues/14679
   - Related to https://github.com/apache/datafusion/pull/14685
   
   ## Rationale for this change
   
   I wanted to help https://github.com/apache/datafusion/issues/14679 by increasing test coverage (and so we were more confident in the fix in https://github.com/apache/datafusion/pull/14685 @blaginin 🙏 )
   
   @mkmik proposed some nice tests in https://github.com/apache/datafusion/issues/14679 so I think it would be good to add test coverage directly
   
   ## What changes are included in this PR?
   
   1. Add tests that `SELECT ... ` from can be round tripped through protouf
   
   ## Are these changes tested?
   They are only tests
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   3. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   There are no user facing changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add additional protobuf tests for plans that read parquet with projections [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #14924:
URL: https://github.com/apache/datafusion/pull/14924


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add additional protobuf tests for plans that read parquet with projections [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14924:
URL: https://github.com/apache/datafusion/pull/14924#issuecomment-2691030177

   > thanks @alamb
   
   @blaginin and @mertak-synnada  and @xudong963 did all the work !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add additional protobuf tests for plans that read parquet with projections [datafusion]

Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #14924:
URL: https://github.com/apache/datafusion/pull/14924#issuecomment-2690491927

   thanks @alamb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add additional protobuf tests for plans that read parquet with projections [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14924:
URL: https://github.com/apache/datafusion/pull/14924#issuecomment-2690433687

   Thank you for the review @xudong963 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add additional protobuf tests for plans that read parquet with projections [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14924:
URL: https://github.com/apache/datafusion/pull/14924#issuecomment-2690432919

   > @alamb wrong Marko :-)
   
   Sorry about that -- I meant @milenkovicm (but it was nice to see you online 👋 )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add additional protobuf tests for plans that read parquet with projections [datafusion]

Posted by "mkmik (via GitHub)" <gi...@apache.org>.
mkmik commented on PR #14924:
URL: https://github.com/apache/datafusion/pull/14924#issuecomment-2689934192

   @alamb wrong Marko :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org