You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/02 22:22:04 UTC

[GitHub] [cordova-android] raphinesse opened a new pull request #1016: refactor: save ProjectBuilder instance in Api instance

raphinesse opened a new pull request #1016:
URL: https://github.com/apache/cordova-android/pull/1016


   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   This reduces dependence on the `builders` module and reduces repetition.
   
   This also facilitates another WIP refactoring I am working on.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Create a single `ProjectBuilder` instance during `Api` construction and use that instance everywhere it is accessible.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Existing tests pass.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] raphinesse merged pull request #1016: refactor: save ProjectBuilder instance in Api instance

Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #1016:
URL: https://github.com/apache/cordova-android/pull/1016


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org