You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/03/18 23:08:18 UTC

[kudu-CR](branch-1.9.x) [master] log on longer location mapping command runs

Hello Will Berkeley, Kudu Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/12785

to review the following change.


Change subject: [master] log on longer location mapping command runs
......................................................................

[master] log on longer location mapping command runs

This patch adds INFO logging when it takes more than 1 second
to run the location mapping command.

Change-Id: Icc420c704b1fad8bddd54285f1a9aa12b71095f0
Reviewed-on: http://gerrit.cloudera.org:8080/12644
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 4d4552d06934f14ed608cf6eb330428df6e8368d)
---
M src/kudu/master/location_cache.cc
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/12785/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc420c704b1fad8bddd54285f1a9aa12b71095f0
Gerrit-Change-Number: 12785
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR](branch-1.9.x) [master] log on longer location mapping command runs

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12785 )

Change subject: [master] log on longer location mapping command runs
......................................................................

[master] log on longer location mapping command runs

This patch adds INFO logging when it takes more than 1 second
to run the location mapping command.

Change-Id: Icc420c704b1fad8bddd54285f1a9aa12b71095f0
Reviewed-on: http://gerrit.cloudera.org:8080/12644
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 4d4552d06934f14ed608cf6eb330428df6e8368d)
Reviewed-on: http://gerrit.cloudera.org:8080/12785
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/master/location_cache.cc
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc420c704b1fad8bddd54285f1a9aa12b71095f0
Gerrit-Change-Number: 12785
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR](branch-1.9.x) [master] log on longer location mapping command runs

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12785 )

Change subject: [master] log on longer location mapping command runs
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc420c704b1fad8bddd54285f1a9aa12b71095f0
Gerrit-Change-Number: 12785
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 19 Mar 2019 17:44:26 +0000
Gerrit-HasComments: No