You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2016/05/08 21:09:17 UTC
[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/12992
[SPARK-15216] [SQL] Add a new Dataset API explainCodegen
#### What changes were proposed in this pull request?
Reading codegen output is important for developers to debug. So far, outputting codegen results is available in the SQL interface by `EXPLAIN CODEGEN`. However, in the Dataset/DataFrame APIs, we face the same issue.
This PR is to add a new Dataset API `explainCodegen` for achieving the same purpose.
BTW, I also tried another way, i.e., adding a new boolean parameter into the existing `explain` API. However, if users set both `extended` and `codegen` to `true`, we only output the `codegen` results to the console. Basically, that is not allowed. We need to issue an exception in that case? Or change the behavior? Output both results in this case? Anyway, I am also fine if this is preferred.
#### How was this patch tested?
Since `explainCodegen` is writing the result to the console, I only do the manual testing in my local environment. For example, the test case:
```scala
test("explainCodegen") {
val ds = Seq("a" -> 1, "a" -> 3, "b" -> 3).toDS().groupByKey(_._1).agg(
expr("avg(_2)").as[Double],
ComplexResultAgg.toColumn)
ds.explainCodegen()
}
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark explainCodeGen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12992.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12992
----
commit f716b106ede5f090c12e261d64ac5fb4ae0af8a4
Author: gatorsmile <ga...@gmail.com>
Date: 2016-05-08T20:53:44Z
a explainCodegen debug API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12992#issuecomment-217750329
**[Test build #58111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58111/consoleFull)** for PR 12992 at commit [`f716b10`](https://github.com/apache/spark/commit/f716b106ede5f090c12e261d64ac5fb4ae0af8a4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12992#issuecomment-217750373
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12992#issuecomment-217952985
No - I don't think this should go in the public API. This is hardly relevant to end users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12992#issuecomment-217864072
uh,,, I see. Should we move it to the DataSet public API?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/12992
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12992#issuecomment-217746435
**[Test build #58111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58111/consoleFull)** for PR 12992 at commit [`f716b10`](https://github.com/apache/spark/commit/f716b106ede5f090c12e261d64ac5fb4ae0af8a4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12992#issuecomment-217970821
Ok, let me close it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12992#issuecomment-217746275
cc @rxin Let me know if this PR is valid. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12992#issuecomment-217788397
@gatorsmile we already have such API, see:
https://github.com/apache/spark/blob/8dc3987d095ae01ad80c89b8f052f231e0807990/sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala#L102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15216] [SQL] Add a new Dataset API expl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12992#issuecomment-217750374
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58111/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org