[GitHub] KazydubB commented on a change in pull request #1557: DRILL-6863: Drop table is not working if path within workspace starts…

[GitBox <gi...@apache.org>]

KazydubB commented on a change in pull request #1557: DRILL-6863: Drop table is not working if path within workspace starts…
URL: https://github.com/apache/drill/pull/1557#discussion_r237193678
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/TestDropTable.java
 ##########
 @@ -21,23 +21,28 @@
 import org.apache.drill.categories.UnlikelyTest;
 import org.apache.drill.common.exceptions.UserException;
 import org.apache.hadoop.fs.Path;
+import org.junit.BeforeClass;
 import org.junit.Test;
 import org.junit.Assert;
 import org.junit.experimental.categories.Category;
 
 @Category(SqlTest.class)
 public class TestDropTable extends PlanTestBase {
 
-  private static final String CREATE_SIMPLE_TABLE = "create table %s as select 1 from cp.`employee.json`";
-  private static final String CREATE_SIMPLE_VIEW = "create view %s as select 1 from cp.`employee.json`";
-  private static final String DROP_TABLE = "drop table %s";
-  private static final String DROP_TABLE_IF_EXISTS = "drop table if exists %s";
-  private static final String DROP_VIEW_IF_EXISTS = "drop view if exists %s";
-  private static final String BACK_TICK = "`";
+  private static final String CREATE_SIMPLE_TABLE = "create table `%s` as select 1 from cp.`employee.json`";
 
 Review comment:
   Surrounded `%s` with '`' (backtick) to allow table names containing '/'.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services