You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2017/04/21 10:28:18 UTC

[GitHub] flink issue #3692: FLINK-5974 Added configurations to support mesos-dns host...

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3692
  
    Looks good to me. Thanks @EronWright for also checking this out...
    
    Only minor request I have would be to use something like `MesosConfigOptions` to store the config keys. We are trying to move away from the pure String based config constants. Have a look at the `YarnConfigOptions` for an example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---