You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/12 18:07:38 UTC

[GitHub] [skywalking] joacatito opened a new issue #5477: Current branch 'master' => OALRuntime.java => line 167 => streamAnnotationListenerMetricsPersistentWorker.notify

joacatito opened a new issue #5477:
URL: https://github.com/apache/skywalking/issues/5477


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [X] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   master branch, windows 10, JRE 1.8.0_211
   - Which company or project?
   OALRT
   - What happened?
   On line 167, probably a misspeling.
   
   The current line have this instruction: 
   ```java
   streamAnnotationListenerMetricsPersistentWorker.notify(metricsClass);
   ```
   
   I guess the correct must be:  
   ```java
   streamAnnotationListener.notify(metricsClass);
   ```
   
   I've just followed the instructions at How-to-build.
   
   Tks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5477: Current branch 'master' => OALRuntime.java => line 167 => streamAnnotationListenerMetricsPersistentWorker.notify

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5477:
URL: https://github.com/apache/skywalking/issues/5477#issuecomment-691581863


   The L167 is like this.
   https://github.com/apache/skywalking/blob/master/oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java#L167
   
   What is the issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng closed issue #5477: Current branch 'master' => OALRuntime.java => line 167 => streamAnnotationListenerMetricsPersistentWorker.notify

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5477:
URL: https://github.com/apache/skywalking/issues/5477


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org