You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/10/20 12:15:08 UTC

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #5052: YARN-11356. Upgrade DataTables to 1.11.5 to fix CVEs

K0K0V0K commented on code in PR #5052:
URL: https://github.com/apache/hadoop/pull/5052#discussion_r1000546604


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.11.5/css/jquery.dataTables.css:
##########
@@ -1,21 +1,3 @@
-/**

Review Comment:
   Do we need this? I mean is it OK to add "The ASF licenses this file to you under the Apache License, Version 2.0 (the "License")" if the JS pair of this file this
   `opyright 2008-2021 SpryMedia Ltd.
   
    This source file is free software, available under the following license:
      MIT license - http://datatables.net/license
   `



##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/dt-1.11.5/css/jquery.dataTables.css:
##########
@@ -1,21 +1,3 @@
-/**

Review Comment:
   Do we need this? I mean is it OK to add "The ASF licenses this file to you under the Apache License, Version 2.0 (the "License")" if the JS pair of this file this
   
   `Copyright 2008-2021 SpryMedia Ltd.
   
    This source file is free software, available under the following license:
      MIT license - http://datatables.net/license
   `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org