[jira] [Commented] (PHOENIX-6378) Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354266#comment-17354266 ] 

ASF GitHub Bot commented on PHOENIX-6378:
-----------------------------------------

stoty commented on a change in pull request #1239:
URL: https://github.com/apache/phoenix/pull/1239#discussion_r642280324



##########
File path: bin/phoenix_utils.py
##########
@@ -77,10 +77,16 @@ def findClasspath(command_name):
     return tryDecode(subprocess.Popen(command, shell=True, stdout=subprocess.PIPE).stdout.read())
 
 def setPath():
-    PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client-hbase-*[!s].jar"
+    PHOENIX_CLIENT_EMBEDDED_JAR_PATTERN = "phoenix-client-embedded-hbase-*[!s].jar"
     PHOENIX_TRACESERVER_JAR_PATTERN = "phoenix-tracing-webapp-*-runnable.jar"
     PHOENIX_TESTS_JAR_PATTERN = "phoenix-core-*-tests*.jar"
     PHOENIX_PHERF_JAR_PATTERN = "phoenix-pherf-*[!s].jar"
+    SLF4J_JAR_PATTERN = "slf4j-log4j12-*[!s].jar"

Review comment:
       Please change the slf4j* variable names to slf4j_log4j12_* for clarity.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Unbunldle sqqline from phoenix-client-embedded, and use it in sqlline.py
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-6378
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6378
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 5.1.0, 4.16.0
>            Reporter: Istvan Toth
>            Assignee: Richárd Antal
>            Priority: Major
>
> Ship sqlline separately, and adjust sqlline.py to load it.
> FYI [~dbwong]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)