[GitHub] [spark] mridulm commented on a change in pull request #32283: [SPARK-34674][CORE][K8S] Close SparkContext after the Main method has finished

[GitBox <gi...@apache.org>]

mridulm commented on a change in pull request #32283:
URL: https://github.com/apache/spark/pull/32283#discussion_r670906664



##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -952,6 +952,15 @@ private[spark] class SparkSubmit extends Logging {
     } catch {
       case t: Throwable =>
         throw findCause(t)
+    } finally {
+      if (!isShell(args.primaryResource) && !isSqlShell(args.mainClass) &&

Review comment:
       +1 to making it k8s specific ...
   Ideally, we should be using daemon threads for most of our background work ...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org