You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/21 12:30:03 UTC
[GitHub] [camel] JiriOndrusek opened a new pull request #4487: CAMEL-15679 LevelDB: Replacing of serizalization + legacy component
JiriOndrusek opened a new pull request #4487:
URL: https://github.com/apache/camel/pull/4487
fixes https://issues.apache.org/jira/browse/CAMEL-15679
PR creates legacy component **camel-leveldb-legacy** (with preserved history)
and then adds new component **camel-leveldb**, which uses different serialization (by default uses java serialization), but also provides another implementation (using Jackson) and interface to add completely custom serialization.
All tests are executed with default and jackson serialization.
Documentation is changed
@davsclaus I'm not sure if this is the correct solution of preserving git history of modules.
From my PoV it would be nice if both modules (new one and legacy one) could have the same history (for the time when the legacy one will be removed), but I didn't find a way of doing it. (it worked only on local repo with more commits)
Should current state (legacy module keeps history and new module is created as new) correct?
I know that these changes look bigger in this compare, but it is caused mainly by the fact that new component is created as new (so there is no diff with the original one). I've kept these changes also from the WIP, where commits are smaller (https://github.com/apache/camel/compare/master...JiriOndrusek:CAMEL-15679-leveldb-jackson-serialization)
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] PascalSchumacher commented on pull request #4487: CAMEL-15679 LevelDB: Replacing of serizalization + legacy component
Posted by GitBox <gi...@apache.org>.
PascalSchumacher commented on pull request #4487:
URL: https://github.com/apache/camel/pull/4487#issuecomment-715884053
Was the file `catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/schemas/camel-blueprint.xsd` added by mistake?
I do not think it is related to this change.
Or am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4487: CAMEL-15679 LevelDB: Replacing of serizalization + legacy component
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4487:
URL: https://github.com/apache/camel/pull/4487
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] PascalSchumacher commented on pull request #4487: CAMEL-15679 LevelDB: Replacing of serizalization + legacy component
Posted by GitBox <gi...@apache.org>.
PascalSchumacher commented on pull request #4487:
URL: https://github.com/apache/camel/pull/4487#issuecomment-716121323
I deleted the file: https://github.com/apache/camel/commit/d9d22ce7c55cce3e6f6d9b7ded29cfa4d7615679
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4487: CAMEL-15679 LevelDB: Replacing of serizalization + legacy component
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4487:
URL: https://github.com/apache/camel/pull/4487#issuecomment-715884775
It must be removed
Il sab 24 ott 2020, 10:58 Pascal Schumacher <no...@github.com> ha
scritto:
> Was the file
> catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/schemas/camel-blueprint.xsd
> added by mistake?
>
> I do not think it is related to this change.
>
> Or am I missing something?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel/pull/4487#issuecomment-715884053>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABG6XV4YGDXGCHEAH2FP3IDSMKJMLANCNFSM4SZWY2JQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org