You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Christian Schulte <cs...@schulte.it> on 2017/01/16 01:48:49 UTC
[IT MNG-5958 - Take 2]: Please review integration test for MNG-5958
Commit to review is here:
<https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c229fb46773>
If no one objects until Thursday, 19th, 2017, I'll merge it to master.
Regards,
--
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958
Posted by Anton Tanasenko <at...@gmail.com>.
Awesome, thanks!
2017-01-26 21:24 GMT+02:00 Christian Schulte <cs...@schulte.it>:
> Am 01/25/17 um 23:52 schrieb Christian Schulte:
> > Am 01/25/17 um 23:44 schrieb Christian Schulte:
> >> Am 01/16/17 um 02:48 schrieb Christian Schulte:
> >>> Commit to review is here:
> >>>
> >>> <https://git-wip-us.apache.org/repos/asf?p=maven-
> integration-testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c
> 229fb46773>
> >>>
> >>> If no one objects until Thursday, 19th, 2017, I'll merge it to master.
> >>>
> >>> Regards,
> >>>
> >>
> >> I just rebased the branches against current master as of today. If the
> >> build runs through successfully, I'll merge to master. Final commit is:
> >>
> >> <https://git-wip-us.apache.org/repos/asf?p=maven-
> integration-testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c
> 229fb46773>
> >>
> >> Corresponding to the following change in the core:
> >>
> >> <https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> 1cdd0c2be545200a11d74c1055dcd0b16d96adc3>
> >>
> >> Regards,
> >>
> >
> > To clarify: It won't be possible to run the non-updated (tagged?) core
> > ITs against Maven >= 3.5.0. This is what made us reset the branches. You
> > need to review this, if you are going to run the non-updated ITs against
> > what will be voted for release.
> >
> > @Anton Tanasenko:
> > If what I just wrote is incorrect, please comment here. Thank you.
> >
> > Regards,
> >
>
> Merged to master.
>
>
--
Regards,
Anton.
Re: [IT MNG-5958 - Take 2]: Please review integration test for
MNG-5958
Posted by Christian Schulte <cs...@schulte.it>.
Am 01/25/17 um 23:52 schrieb Christian Schulte:
> Am 01/25/17 um 23:44 schrieb Christian Schulte:
>> Am 01/16/17 um 02:48 schrieb Christian Schulte:
>>> Commit to review is here:
>>>
>>> <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c229fb46773>
>>>
>>> If no one objects until Thursday, 19th, 2017, I'll merge it to master.
>>>
>>> Regards,
>>>
>>
>> I just rebased the branches against current master as of today. If the
>> build runs through successfully, I'll merge to master. Final commit is:
>>
>> <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c229fb46773>
>>
>> Corresponding to the following change in the core:
>>
>> <https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=1cdd0c2be545200a11d74c1055dcd0b16d96adc3>
>>
>> Regards,
>>
>
> To clarify: It won't be possible to run the non-updated (tagged?) core
> ITs against Maven >= 3.5.0. This is what made us reset the branches. You
> need to review this, if you are going to run the non-updated ITs against
> what will be voted for release.
>
> @Anton Tanasenko:
> If what I just wrote is incorrect, please comment here. Thank you.
>
> Regards,
>
Merged to master.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [IT MNG-5958 - Take 2]: Please review integration test for
MNG-5958
Posted by Christian Schulte <cs...@schulte.it>.
Am 01/25/17 um 23:44 schrieb Christian Schulte:
> Am 01/16/17 um 02:48 schrieb Christian Schulte:
>> Commit to review is here:
>>
>> <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c229fb46773>
>>
>> If no one objects until Thursday, 19th, 2017, I'll merge it to master.
>>
>> Regards,
>>
>
> I just rebased the branches against current master as of today. If the
> build runs through successfully, I'll merge to master. Final commit is:
>
> <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c229fb46773>
>
> Corresponding to the following change in the core:
>
> <https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=1cdd0c2be545200a11d74c1055dcd0b16d96adc3>
>
> Regards,
>
To clarify: It won't be possible to run the non-updated (tagged?) core
ITs against Maven >= 3.5.0. This is what made us reset the branches. You
need to review this, if you are going to run the non-updated ITs against
what will be voted for release.
@Anton Tanasenko:
If what I just wrote is incorrect, please comment here. Thank you.
Regards,
--
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [IT MNG-5958 - Take 2]: Please review integration test for
MNG-5958
Posted by Christian Schulte <cs...@schulte.it>.
Am 01/16/17 um 02:48 schrieb Christian Schulte:
> Commit to review is here:
>
> <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c229fb46773>
>
> If no one objects until Thursday, 19th, 2017, I'll merge it to master.
>
> Regards,
>
I just rebased the branches against current master as of today. If the
build runs through successfully, I'll merge to master. Final commit is:
<https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c229fb46773>
Corresponding to the following change in the core:
<https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=1cdd0c2be545200a11d74c1055dcd0b16d96adc3>
Regards,
--
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [IT MNG-5958 - Take 2]: Please review integration test for
MNG-5958
Posted by Christian Schulte <cs...@schulte.it>.
Am 01/20/17 um 00:30 schrieb Christian Schulte:
> Am 01/20/17 um 00:09 schrieb Anton Tanasenko:
>> New ITs should run successfully against 3.3.9 and 3.5.0-SNAPSHOT+changes.
>> It doesn't make sense to test a feature which is not in.
>
> The Maven core master branch of the maven-jenkinsfile job is at
> 3.5.0-SNAPSHOT. If the updated ITs are run (from the MNG-5958 branch)
> against that master branch (without the MNG-5958 changes) instead of the
> MNG-5958 branch, the ITs would fail. That would be expected. Showing the
> updated ITs do run successfully against 3.5.0-SNAPSHOT means they need
> to run from the MNG-5958 branch against the core MNG-5958 branch. If we
> want to show that the updated ITs still run successfully against 3.3.9
> in addition, we would need to add that to the pipeline (run the updated
> ITs from the MNG-5958 branch against Maven 3.3.9 instead of
> 3.5.0-SNAPSHOT). That would make sense. I would not mind if this job
> takes 3 days to complete.
>
> Regards,
>
While at it: Adding the plugin ITs to that pipeline also makes a lot of
sense. So that the core integration testing ITs need to succeed and all
plugin ITs also need to succeed. There is this minor issue that you will
build the trunk of the plugins for this to have an easy setup. Otherwise
you would need to update that Jenkinsfile whenever a new plugin is
released to the most recent tag. Well. Maybe all released versions of
all plugins. I also would not mind if this job takes a whole month to
complete. Hmm. Ok. That'd be a bit too long.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [IT MNG-5958 - Take 2]: Please review integration test for
MNG-5958
Posted by Christian Schulte <cs...@schulte.it>.
Am 01/20/17 um 00:09 schrieb Anton Tanasenko:
> New ITs should run successfully against 3.3.9 and 3.5.0-SNAPSHOT+changes.
> It doesn't make sense to test a feature which is not in.
The Maven core master branch of the maven-jenkinsfile job is at
3.5.0-SNAPSHOT. If the updated ITs are run (from the MNG-5958 branch)
against that master branch (without the MNG-5958 changes) instead of the
MNG-5958 branch, the ITs would fail. That would be expected. Showing the
updated ITs do run successfully against 3.5.0-SNAPSHOT means they need
to run from the MNG-5958 branch against the core MNG-5958 branch. If we
want to show that the updated ITs still run successfully against 3.3.9
in addition, we would need to add that to the pipeline (run the updated
ITs from the MNG-5958 branch against Maven 3.3.9 instead of
3.5.0-SNAPSHOT). That would make sense. I would not mind if this job
takes 3 days to complete.
Regards,
--
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [IT MNG-5958 - Take 2]: Please review integration test for
MNG-5958
Posted by Christian Schulte <cs...@schulte.it>.
Am 01/20/17 um 01:02 schrieb Stephen Connolly:
> Ok in that case create a throwaway fork of your branch with changes that
> uses the changed integration tests
>
> If that passes we can throw away the throwaway branch and merge both.
<https://builds.apache.org/job/maven-jenkinsfile/job/MNG-5958-jenkinsfile/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958
Posted by Stephen Connolly <st...@gmail.com>.
Ok in that case create a throwaway fork of your branch with changes that
uses the changed integration tests
If that passes we can throw away the throwaway branch and merge both.
(Need for throwaway branch will go away soon... I'm just trying to bash
bugs in updates to Jenkins plugins to enable the feature we require)
On Thu 19 Jan 2017 at 23:09, Anton Tanasenko <at...@gmail.com>
wrote:
> New ITs should run successfully against 3.3.9 and 3.5.0-SNAPSHOT+changes.
>
> It doesn't make sense to test a feature which is not in.
>
>
>
> 2017-01-19 22:46 GMT+02:00 Christian Schulte <cs...@schulte.it>:
>
>
>
> > Am 01/19/17 um 13:06 schrieb Stephen Connolly:
>
> > > Ideal would be to create a *new throw-away branch* that is forked from
>
> > > current master and just changes the itBranch in the Jenkinsfile to the
>
> > > integration test branch you want to merge.
>
> >
>
> > To verify the changes to the ITs are working without any changes to the
>
> > core? Verify the new ITs can be run successfully without any changes in
>
> > the core? This won't work because the updated ITs are testing the
>
> > updated behaviour which would not be there. The added ITs would fail
>
> > without the corresponding changes. Running the updated core against the
>
> > updated ITs is the only way to show the ITs can be run successfully.
>
> >
>
> >
>
> > ---------------------------------------------------------------------
>
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> >
>
> >
>
>
>
>
>
> --
>
> Regards,
>
> Anton.
>
> --
Sent from my phone
Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958
Posted by Anton Tanasenko <at...@gmail.com>.
New ITs should run successfully against 3.3.9 and 3.5.0-SNAPSHOT+changes.
It doesn't make sense to test a feature which is not in.
2017-01-19 22:46 GMT+02:00 Christian Schulte <cs...@schulte.it>:
> Am 01/19/17 um 13:06 schrieb Stephen Connolly:
> > Ideal would be to create a *new throw-away branch* that is forked from
> > current master and just changes the itBranch in the Jenkinsfile to the
> > integration test branch you want to merge.
>
> To verify the changes to the ITs are working without any changes to the
> core? Verify the new ITs can be run successfully without any changes in
> the core? This won't work because the updated ITs are testing the
> updated behaviour which would not be there. The added ITs would fail
> without the corresponding changes. Running the updated core against the
> updated ITs is the only way to show the ITs can be run successfully.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Regards,
Anton.
Re: [IT MNG-5958 - Take 2]: Please review integration test for
MNG-5958
Posted by Christian Schulte <cs...@schulte.it>.
Am 01/19/17 um 13:06 schrieb Stephen Connolly:
> Ideal would be to create a *new throw-away branch* that is forked from
> current master and just changes the itBranch in the Jenkinsfile to the
> integration test branch you want to merge.
To verify the changes to the ITs are working without any changes to the
core? Verify the new ITs can be run successfully without any changes in
the core? This won't work because the updated ITs are testing the
updated behaviour which would not be there. The added ITs would fail
without the corresponding changes. Running the updated core against the
updated ITs is the only way to show the ITs can be run successfully.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958
Posted by Stephen Connolly <st...@gmail.com>.
Ideal would be to create a *new throw-away branch* that is forked from
current master and just changes the itBranch in the Jenkinsfile to the
integration test branch you want to merge.
If those integration tests do not pass on master then that is a different
story.
On 19 January 2017 at 12:01, Christian Schulte <cs...@schulte.it> wrote:
> Am 19.01.2017 um 12:37 schrieb Stephen Connolly:
> > If you need to run against a different IT branch, then change
> > https://github.com/apache/maven/blob/master/Jenkinsfile#L22 to point to
> the
> > branch on integration tests here are the options:
> >
> > 1. (Ideal option) Create a *throwaway* branch on maven.git specifically
> for
> > the integration test run where you change
> > https://github.com/apache/maven/blob/master/Jenkinsfile#L22 to point to
> > your maven-integration-testing.git branch name. Get a clean run on that
> > *throwaway* branch and then merge the integration tests and throw-away
> the
> > throw-away branch.
>
> To confirm: I should update the Jenkinsfile on the MNG-5958 branch to
> run the ITs of that said branch? When merging to master, I will revert
> the changes to the Jenkinsfile first on the branch (using git revert)
> and will squash all of this before the merge so that there is only one
> single commit going to the master branch?
>
> The failing IT just shows that there are changes in core making an
> existing IT fail. This is documented in the initial review request
> thread on this mailing list.
>
> Could you also verify the ranges used in the updated tests, please?
>
> Regards,
> --
> Christian
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [IT MNG-5958 - Take 2]: Please review integration test for
MNG-5958
Posted by Christian Schulte <cs...@schulte.it>.
Am 19.01.2017 um 12:37 schrieb Stephen Connolly:
> If you need to run against a different IT branch, then change
> https://github.com/apache/maven/blob/master/Jenkinsfile#L22 to point to the
> branch on integration tests here are the options:
>
> 1. (Ideal option) Create a *throwaway* branch on maven.git specifically for
> the integration test run where you change
> https://github.com/apache/maven/blob/master/Jenkinsfile#L22 to point to
> your maven-integration-testing.git branch name. Get a clean run on that
> *throwaway* branch and then merge the integration tests and throw-away the
> throw-away branch.
To confirm: I should update the Jenkinsfile on the MNG-5958 branch to
run the ITs of that said branch? When merging to master, I will revert
the changes to the Jenkinsfile first on the branch (using git revert)
and will squash all of this before the merge so that there is only one
single commit going to the master branch?
The failing IT just shows that there are changes in core making an
existing IT fail. This is documented in the initial review request
thread on this mailing list.
Could you also verify the ranges used in the updated tests, please?
Regards,
--
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958
Posted by Stephen Connolly <st...@gmail.com>.
This will all be easier once JENKINS-40906 is fixed fully and available on
builds.apache.org
On 19 January 2017 at 11:37, Stephen Connolly <
stephen.alan.connolly@gmail.com> wrote:
> If you need to run against a different IT branch, then change
> https://github.com/apache/maven/blob/master/Jenkinsfile#L22 to point to
> the branch on integration tests here are the options:
>
> 1. (Ideal option) Create a *throwaway* branch on maven.git specifically
> for the integration test run where you change https://github.com/apache/
> maven/blob/master/Jenkinsfile#L22 to point to your
> maven-integration-testing.git branch name. Get a clean run on that
> *throwaway* branch and then merge the integration tests and throw-away the
> throw-away branch.
>
> This lets us see that the integration tests remain passing without code
> changes.
>
> 2. (OK option) using https://builds.apache.org/job/maven-jenkinsfile/job/
> MNG-5958/lastCompletedBuild/replay/ if you can login to Jenkins
>
> We need to go look at the Jenkinsfile that you ran and we do not have
> tracability of the diff... plus you are running the tests with the new
> changed code... may want to consider this in conjunction with #1 if you
> have any doubt that the new code will not work with the new tests
>
> 3. (Yuk option) push the change to your branch, get the passing build,
> then force push your branch back to HEAD^1
>
> On 19 January 2017 at 11:30, Stephen Connolly <
> stephen.alan.connolly@gmail.com> wrote:
>
>> https://builds.apache.org/job/maven-jenkinsfile/job/MNG-5958/ is failing
>>
>> Do not commit without showing a passing build
>>
>> On 19 January 2017 at 11:12, Christian Schulte <cs...@schulte.it> wrote:
>>
>>> Am 16.01.2017 um 02:48 schrieb Christian Schulte:
>>> > Commit to review is here:
>>> >
>>> > <https://git-wip-us.apache.org/repos/asf?p=maven-integration
>>> -testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c229fb46773>
>>> >
>>> > If no one objects until Thursday, 19th, 2017, I'll merge it to master.
>>>
>>> If no one objects, I will merge it in a few hours.
>>>
>>> Regards,
>>> --
>>> Christian
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>
>
Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958
Posted by Stephen Connolly <st...@gmail.com>.
If you need to run against a different IT branch, then change
https://github.com/apache/maven/blob/master/Jenkinsfile#L22 to point to the
branch on integration tests here are the options:
1. (Ideal option) Create a *throwaway* branch on maven.git specifically for
the integration test run where you change
https://github.com/apache/maven/blob/master/Jenkinsfile#L22 to point to
your maven-integration-testing.git branch name. Get a clean run on that
*throwaway* branch and then merge the integration tests and throw-away the
throw-away branch.
This lets us see that the integration tests remain passing without code
changes.
2. (OK option) using
https://builds.apache.org/job/maven-jenkinsfile/job/MNG-5958/lastCompletedBuild/replay/
if you can login to Jenkins
We need to go look at the Jenkinsfile that you ran and we do not have
tracability of the diff... plus you are running the tests with the new
changed code... may want to consider this in conjunction with #1 if you
have any doubt that the new code will not work with the new tests
3. (Yuk option) push the change to your branch, get the passing build, then
force push your branch back to HEAD^1
On 19 January 2017 at 11:30, Stephen Connolly <
stephen.alan.connolly@gmail.com> wrote:
> https://builds.apache.org/job/maven-jenkinsfile/job/MNG-5958/ is failing
>
> Do not commit without showing a passing build
>
> On 19 January 2017 at 11:12, Christian Schulte <cs...@schulte.it> wrote:
>
>> Am 16.01.2017 um 02:48 schrieb Christian Schulte:
>> > Commit to review is here:
>> >
>> > <https://git-wip-us.apache.org/repos/asf?p=maven-integration
>> -testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c229fb46773>
>> >
>> > If no one objects until Thursday, 19th, 2017, I'll merge it to master.
>>
>> If no one objects, I will merge it in a few hours.
>>
>> Regards,
>> --
>> Christian
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958
Posted by Stephen Connolly <st...@gmail.com>.
https://builds.apache.org/job/maven-jenkinsfile/job/MNG-5958/ is failing
Do not commit without showing a passing build
On 19 January 2017 at 11:12, Christian Schulte <cs...@schulte.it> wrote:
> Am 16.01.2017 um 02:48 schrieb Christian Schulte:
> > Commit to review is here:
> >
> > <https://git-wip-us.apache.org/repos/asf?p=maven-
> integration-testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c
> 229fb46773>
> >
> > If no one objects until Thursday, 19th, 2017, I'll merge it to master.
>
> If no one objects, I will merge it in a few hours.
>
> Regards,
> --
> Christian
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [IT MNG-5958 - Take 2]: Please review integration test for
MNG-5958
Posted by Christian Schulte <cs...@schulte.it>.
Am 16.01.2017 um 02:48 schrieb Christian Schulte:
> Commit to review is here:
>
> <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=2fd74ac6d4747b11d50b78965f0d2c229fb46773>
>
> If no one objects until Thursday, 19th, 2017, I'll merge it to master.
If no one objects, I will merge it in a few hours.
Regards,
--
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org