[GitHub] dangogh commented on a change in pull request #3286: Pattern-based consistent hashing feature for TR/TO/TP

[GitBox <gi...@apache.org>]

dangogh commented on a change in pull request #3286: Pattern-based consistent hashing feature for TR/TO/TP
URL: https://github.com/apache/trafficcontrol/pull/3286#discussion_r254377044
 
 

 ##########
 File path: docs/source/admin/traffic_router.rst
 ##########
 @@ -595,3 +595,33 @@ set in ``/lib/systemd/system/traffic_router.service``.
   	-XX:+UseG1GC \
   	-XX:+UnlockExperimentalVMOptions \
   	-XX:InitiatingHeapOccupancyPercent=30"
+
+Pattern Based Consistent Hashing Feature
+========================================
+
+Overview
+--------
+Pattern based consistent hashing is a feature to modify the request path given to Traffic Router's consistent hasher for Cache selection (and Delivery Service selection for Steering Delivery Services) using a regex. This new regex field 'Consistent Hash Regex' uses a per-Delivery Service basis and is given to Traffic Router via the CRConfig. The purpose of this feature is to increase cache efficiency by directing requests for the same asset, but with varying request paths, to the same cache.
+
 
 Review comment:
   I'd change that wording a little -- instead of this:
   
   "This new regex field 'Consistent Hash Regex' uses a per-Delivery Service basis..." 
   
   how about this?
   
   "This new regex field 'Consistent Hash Regex' is applied on a per-Delivery Service basis..." 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services