[jira] Resolved: (BUILDR-392) Array values not flattened in (one version) of eclipse task properties

["Alex Boisvert (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BUILDR-392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert resolved BUILDR-392.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4

Patch applied.  Thanks guys!

Sending        CHANGELOG
Sending        lib/buildr/ide/eclipse.rb
Sending        spec/ide/eclipse_spec.rb
Transmitting file data ...
Committed revision 919294.


> Array values not flattened in (one version) of eclipse task properties
> ----------------------------------------------------------------------
>
>                 Key: BUILDR-392
>                 URL: https://issues.apache.org/jira/browse/BUILDR-392
>             Project: Buildr
>          Issue Type: Bug
>          Components: IDE
>    Affects Versions: 1.3.5
>            Reporter: Peter Dettman
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: BUILDR-392.txt
>
>
> In the section of the docs on Eclipse (http://buildr.apache.org/more_stuff.html#eclipse), this example is given:
>     eclipse.builders ['org.eclipse.pde.ManifestBuilder', 'org.eclipse.pde.SchemaBuilder']
> That actually doesn't work, because it is handled by (eclipse.rb r902466):
>       def natures(*values)
>         if values.size > 0
>           @natures ||= []
>           @natures += values # <-- This should be values.flatten?
>         else
>           @natures || (@project.parent ? @project.parent.eclipse.natures : [])
>         end
>       end
> it DOES work if assignment is used:
>     eclipse.builders = ['org.eclipse.pde.ManifestBuilder', 'org.eclipse.pde.SchemaBuilder']
> or no explicit array added:
>     eclipse.builders 'org.eclipse.pde.ManifestBuilder', 'org.eclipse.pde.SchemaBuilder'
> I've marked where I think a flatten should be added. By visual inspection, I guess the same problem exists for "classpath_containers", "exclude_libs", and "builders" (also all in eclipse.rb).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.