[GitHub] [incubator-nuttx] patacongo commented on issue #2401: Did #2335 break something?

[GitBox <gi...@apache.org>]

patacongo commented on issue #2401:
URL: https://github.com/apache/incubator-nuttx/issues/2401#issuecomment-734000442


   > 
   > 
   > OK, I will change CATFILE definition so that it does not hang on empty list of input files (a sane expectation). I'm not sure how to adapt the windows case, though. This is how the change looks for the Linux case so far:
   > 
   > ```makefile
   > # CATFILE - Cat a list of files
   > #
   > # USAGE: $(call CATFILE,dest,src1,src2,src3,...)
   > 
   > ifeq ($(CONFIG_WINDOWS_NATIVE),y)
   > define CATFILE
   > 	$(Q) type $(2) > $1
   > endef
   > else
   > define CATFILE
   > 	$(Q) if [ -z $(2) ]; then echo '' > Make.dep; else cat $(2) > $1; fi
   > endef
   > endif
   > ```
   
   Shouldn't cause a hang.  It should generate a (uncaptured) error message and generate an empty file:
   
       C:\Users\spuda>type > foobar
       The syntax of the command is incorrect.
       
       C:\Users\spuda>dir foobar
        Volume in drive C has no label.
        Volume Serial Number is 947F-7817
       
        Directory of C:\Users\spuda
       
       11/25/2020  06:05 PM                 0 foobar
                      1 File(s)              0 bytes
                      0 Dir(s)  943,090,741,248 bytes free
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org