You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/06 11:30:06 UTC
[PR] docs(metrics): document RPC error classifier categories [dubbo-go]
Aias00 opened a new pull request, #3603:
URL: https://github.com/apache/dubbo-go/pull/3603
Add Go doc comments to every ErrorType constant and to classifyError, explaining which Triple/gRPC status code each category maps to and which layer (caller/deadline, back-pressure, service availability, business, network, codec) it represents. Clarify why ErrorTypeNetworkFailure and ErrorTypeCodec are reserved but not yet produced: both candidate source codes collapse into the catch-all CodeInternal, which cannot be split reliably at the status-code level, so they fall through to ErrorTypeUnknown today.
Refs #3598 (task #21)
### Description
Fixes # (issue)
### Checklist
- [x] I confirm the target branch is `develop`
- [x] Code has passed local testing
- [x] I have added tests that prove my fix is effective or that my feature works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] docs(metrics): document RPC error classifier categories [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl merged PR #3603:
URL: https://github.com/apache/dubbo-go/pull/3603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] docs(metrics): document RPC error classifier categories [dubbo-go]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #3603:
URL: https://github.com/apache/dubbo-go/pull/3603#issuecomment-5204105312
Codec errors are not surfaced through a single status code at the protocol layer — they are spread across three different codes:
| Codec failure | Actual code |
| --- | --- |
| marshal / compress / recycle compressor | `CodeInternal` |
| unmarshal / decompress / invalid encoding | `CodeInvalidArgument` |
| envelope read/write I/O / get compressor | `CodeUnknown` |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] docs(metrics): document RPC error classifier categories [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3603:
URL: https://github.com/apache/dubbo-go/pull/3603#issuecomment-5204078192
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3603) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3603&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3603&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3603&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3603&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3603&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3603)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] docs(metrics): document RPC error classifier categories [dubbo-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3603:
URL: https://github.com/apache/dubbo-go/pull/3603#issuecomment-5204106173
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3603?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 53.86%. Comparing base ([`48d6e69`](https://app.codecov.io/gh/apache/dubbo-go/commit/48d6e696e755d46df2425bbf71c413bbd1887f3f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb686e9`](https://app.codecov.io/gh/apache/dubbo-go/commit/bb686e98e2076a943726ed7d92528183544657b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #3603 +/- ##
===========================================
- Coverage 54.57% 53.86% -0.72%
===========================================
Files 460 474 +14
Lines 35443 36388 +945
===========================================
+ Hits 19344 19601 +257
- Misses 14543 15211 +668
- Partials 1556 1576 +20
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go/pull/3603?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] docs(metrics): document RPC error classifier categories [dubbo-go]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #3603:
URL: https://github.com/apache/dubbo-go/pull/3603#issuecomment-5204109138
> Codec errors are not surfaced through a single status code at the protocol layer — they are spread across three different codes:
>
> Codec failure Actual code
> marshal / compress / recycle compressor `CodeInternal`
> unmarshal / decompress / invalid encoding `CodeInvalidArgument`
> envelope read/write I/O / get compressor `CodeUnknown`
should this be handled or later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org