You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by PRAGYA MITTAL <mi...@gmail.com> on 2015/02/24 08:26:24 UTC
Review Request 31345: Add test in falcon to test touch feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31345/
-----------------------------------------------------------
Review request for Falcon and samarth gupta.
Bugs: FALCON-1043
https://issues.apache.org/jira/browse/FALCON-1043
Repository: falcon-git
Description
-------
Adding test case for touch feature for feed/process. Related to https://issues.apache.org/jira/browse/FALCON-949
Diffs
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e11b37d
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 5717923
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/31345/diff/
Testing
-------
Done.
Thanks,
PRAGYA MITTAL
Re: Review Request 31345: Add test in falcon to test touch feature
Posted by PRAGYA MITTAL <mi...@gmail.com>.
> On Feb. 24, 2015, 8:44 a.m., samarth gupta wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java, line 601
> > <https://reviews.apache.org/r/31345/diff/1/?file=873531#file873531line601>
> >
> > we can just pass "data" as param and use Util.readEntityName to get the name inside.
Will make changes in the new patch
> On Feb. 24, 2015, 8:44 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java, line 99
> > <https://reviews.apache.org/r/31345/diff/1/?file=873533#file873533line99>
> >
> > checking to bundle ID should be good enough. this check is not needed. Same with the check in next line for waitTillInstanceAreCreated.
Will make changes in the new patch
> On Feb. 24, 2015, 8:44 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java, line 107
> > <https://reviews.apache.org/r/31345/diff/1/?file=873533#file873533line107>
> >
> > validations till here are good enough. Below 3 line can be removed. They can be removed from rest of the test as well.
Will make changes in the new patch
- PRAGYA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31345/#review73775
-----------------------------------------------------------
On Feb. 24, 2015, 7:26 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31345/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 7:26 a.m.)
>
>
> Review request for Falcon and samarth gupta.
>
>
> Bugs: FALCON-1043
> https://issues.apache.org/jira/browse/FALCON-1043
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Adding test case for touch feature for feed/process. Related to https://issues.apache.org/jira/browse/FALCON-949
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e11b37d
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 5717923
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31345/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 31345: Add test in falcon to test touch feature
Posted by samarth gupta <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31345/#review73775
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java
<https://reviews.apache.org/r/31345/#comment120175>
we can just pass "data" as param and use Util.readEntityName to get the name inside.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java
<https://reviews.apache.org/r/31345/#comment120176>
checking to bundle ID should be good enough. this check is not needed. Same with the check in next line for waitTillInstanceAreCreated.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java
<https://reviews.apache.org/r/31345/#comment120177>
validations till here are good enough. Below 3 line can be removed. They can be removed from rest of the test as well.
- samarth gupta
On Feb. 24, 2015, 7:26 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31345/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 7:26 a.m.)
>
>
> Review request for Falcon and samarth gupta.
>
>
> Bugs: FALCON-1043
> https://issues.apache.org/jira/browse/FALCON-1043
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Adding test case for touch feature for feed/process. Related to https://issues.apache.org/jira/browse/FALCON-949
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e11b37d
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 5717923
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31345/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 31345: Add test in falcon to test touch feature
Posted by samarth gupta <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31345/#review73977
-----------------------------------------------------------
Ship it!
Ship It!
- samarth gupta
On Feb. 24, 2015, 9:50 a.m., PRAGYA MITTAL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31345/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 9:50 a.m.)
>
>
> Review request for Falcon and samarth gupta.
>
>
> Bugs: FALCON-1043
> https://issues.apache.org/jira/browse/FALCON-1043
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Adding test case for touch feature for feed/process. Related to https://issues.apache.org/jira/browse/FALCON-949
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e11b37d
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 5717923
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31345/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> PRAGYA MITTAL
>
>
Re: Review Request 31345: Add test in falcon to test touch feature
Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31345/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 9:50 a.m.)
Review request for Falcon and samarth gupta.
Changes
-------
Patch updated after addressing review board comments
Bugs: FALCON-1043
https://issues.apache.org/jira/browse/FALCON-1043
Repository: falcon-git
Description
-------
Adding test case for touch feature for feed/process. Related to https://issues.apache.org/jira/browse/FALCON-949
Diffs (updated)
-----
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java e11b37d
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 5717923
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TouchAPIPrismAndServerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/31345/diff/
Testing
-------
Done.
Thanks,
PRAGYA MITTAL