You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/02/03 07:20:54 UTC
[GitHub] carbondata pull request #1919: [CARBONDATA-2123] Refactor datamap schema thr...
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1919#discussion_r165807734
--- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/datamap/DataMapProvider.java ---
@@ -27,6 +27,40 @@
*/
public enum DataMapProvider {
- PREAGGREGATE,
- TIMESERIES;
+ PREAGGREGATE("org.apache.carbondata.core.datamap.AggregateDataMap", "preaggregate"),
+ TIMESERIES("org.apache.carbondata.core.datamap.TimeSeriesDataMap", "timeseries");
+
+ /**
+ * Fully qualified class name of datamap
+ */
+ private String className;
+
+ /**
+ * Short name representation of datamap
+ */
+ private String shortName;
+
+ DataMapProvider(String className, String shortName) {
+ this.className = className;
+ this.shortName = shortName;
+ }
+
+ public String getClassName() {
+ return className;
+ }
+
+ private boolean isEqual(String dataMapClass) {
+ return (dataMapClass != null && (dataMapClass.equals(className) ||
+ dataMapClass.equalsIgnoreCase(shortName)));
+ }
+
+ public static DataMapProvider getDataMapProvider(String dataMapClass) {
--- End diff --
suggest change "dataMapClass" to "providerName"
---