You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/16 23:36:00 UTC

[jira] [Updated] (ARROW-15952) [C++] Document Array::accept() and ArrayVisitor

     [ https://issues.apache.org/jira/browse/ARROW-15952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated ARROW-15952:
-----------------------------------
    Labels: pull-request-available  (was: )

> [C++] Document Array::accept() and ArrayVisitor
> -----------------------------------------------
>
>                 Key: ARROW-15952
>                 URL: https://issues.apache.org/jira/browse/ARROW-15952
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 7.0.0
>            Reporter: Will Jones
>            Assignee: Will Jones
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 8.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We mention in the docs that:
> {quote}The classes arrow::Array and its subclasses provide strongly-typed accessors with support for the visitor pattern and other affordances.{quote}
> But ArrayVisitor class and the {{Array::Accept()}} [method|https://github.com/apache/arrow/blob/b956ba51ea11d050745e09548e33aa61fdcbfddc/cpp/src/arrow/array/array_base.h#L136] are missing from the API docs. We should add those, and potentially also provide an example of using the visitor.
> Likely worth doing the same for TypeVisitor and ScalarVisitor. It would also be nice to document the performance implication of using ScalarVisitor vs ArrayVisitor. Also we use an "inline" version of the visitors; is that something we do/should expose in the API as well?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)