You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by m4rkmckenna <gi...@git.apache.org> on 2015/11/24 11:24:54 UTC
[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...
GitHub user m4rkmckenna opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1060
Readding dependency on jackson-jaxrs to brooklyn-rest-client
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/m4rkmckenna/incubator-brooklyn readding-dep-jackson-jaxrs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1060.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1060
----
commit d4e7d2b716ee503d7cbe43be4b0e570fefa3aa10
Author: Mark McKenna <m4...@gmail.com>
Date: 2015-11-23T17:06:29Z
Readding dependency on jackson-jaxrs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1060
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1060#issuecomment-159241967
The Jenkins check is valid this time:
```
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check
(default) on project brooklyn-rest-client: Too many files with unapproved
license: 1 See RAT report in:
/jenkins/workspace/incubator-brooklyn-pull-requests/usage/rest-client/target/rat.txt
-> [Help 1]
```
Put this at the top of the file:
```
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#
```
Could you also squash your commits? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1060#discussion_r45719555
--- Diff: usage/rest-client/src/test/java/org/apache/brooklyn/rest/client/BrooklynApiRestClientTest.java ---
@@ -98,11 +98,21 @@ public void testCatalogApiLocations() throws Exception {
log.info("locations from catalog are: "+locations);
}
+ public void testCatalogCreate()throws Exception {
+ final String bomYaml = "brooklyn.catalog:\n id: simple-tomcat\n version: 1.0\n itemType: template\n" +
--- End diff --
Put a new line in after every `\n` to make this readable. Or alternatively put the blueprint in a file in src/test/resources/path/to/file.yaml and load it with `new ResourceUtils(this).getResourceAsString("classpath://path/to/file.yaml")`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1060#issuecomment-159247878
Added header and squashed .... my bad should have run a build when i added the bom
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1060#issuecomment-159278410
@m4rkmckenna Thanks. Will merge this.
By the way, If you use IntelliJ you can configure it to add the license header automatically when creating new files. See preferences -> editor -> copyright -> copyright profiles. You can probably do the same with Eclipse.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---