You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2014/02/10 14:18:29 UTC
git commit: WICKET-3335 Print the component queue when non-empty in
IQueueRegion#onDetach()
Updated Branches:
refs/heads/sandbox/component-queueing-2 ad41c0cce -> ec85560ea
WICKET-3335 Print the component queue when non-empty in IQueueRegion#onDetach()
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/ec85560e
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/ec85560e
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/ec85560e
Branch: refs/heads/sandbox/component-queueing-2
Commit: ec85560ea069cd99c7d7e016f018137635b0ec11
Parents: ad41c0c
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Feb 10 15:17:13 2014 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon Feb 10 15:17:13 2014 +0200
----------------------------------------------------------------------
.../src/main/java/org/apache/wicket/ComponentQueue.java | 9 +++++++++
.../src/main/java/org/apache/wicket/MarkupContainer.java | 6 +++---
2 files changed, 12 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/ec85560e/wicket-core/src/main/java/org/apache/wicket/ComponentQueue.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/ComponentQueue.java b/wicket-core/src/main/java/org/apache/wicket/ComponentQueue.java
index 758970b..661736c 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ComponentQueue.java
+++ b/wicket-core/src/main/java/org/apache/wicket/ComponentQueue.java
@@ -144,4 +144,13 @@ class ComponentQueue
}
return null;
}
+
+ @Override
+ public String toString()
+ {
+ return "ComponentQueue{" +
+ "queueSize=" + queueSize +
+ ", queue=" + Arrays.toString(queue) +
+ '}';
+ }
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/ec85560e/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
index 19b72aa..ffd5488 100644
--- a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
+++ b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java
@@ -2009,9 +2009,9 @@ public abstract class MarkupContainer extends Component implements Iterable<Comp
if (queue != null && !queue.isEmpty())
{
- // TODO WICKET-3335: Print the queue ?!
- throw new WicketRuntimeException("Detach called on component: " + getId()
- + " while it had a non-empty queue");
+ throw new WicketRuntimeException(
+ String.format("Detach called on component with id '%s' while it had a non-empty queue: %s",
+ getId(), queue));
}
queue = null;
}